Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly check generic method overriding in explicitly-typed anonymous classes #808

Merged
merged 94 commits into from
Sep 29, 2023
Merged

Properly check generic method overriding in explicitly-typed anonymous classes #808

merged 94 commits into from
Sep 29, 2023

Commits on Mar 31, 2023

  1. all changes for handling method overrides

    @NikitaAware @msridhar
    NikitaAware authored and msridhar committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    362ee2f View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Merge branch 'master' into try-method-match

    @msridhar
    msridhar authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    4a690c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. code for pretty printing generic types

    @msridhar
    msridhar committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    ac1e7f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. better printing of types in errors related to generic types

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    241793d View commit details
    Browse the repository at this point in the history

  2. fix compile error on JDK 8

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    7c86f30 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'generic-type-pretty' into try-method-match

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    899f615 View commit details
    Browse the repository at this point in the history

  4. fix

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    90b0c69 View commit details
    Browse the repository at this point in the history

  5. cleanup

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    74837a1 View commit details
    Browse the repository at this point in the history

  6. better error message

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    6e3f2d0 View commit details
    Browse the repository at this point in the history

  7. WIP

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    56cddbe View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into check-toolchains

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    b9d698c View commit details
    Browse the repository at this point in the history

  9. test

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    56fb488 View commit details
    Browse the repository at this point in the history

  10. reorder

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    304e567 View commit details
    Browse the repository at this point in the history

  11. just windows

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    7381c6e View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into generic-type-pretty

    @msridhar
    msridhar authored Apr 27, 2023
    Configuration menu
    Copy the full SHA
    2689a62 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'check-toolchains' into generic-type-pretty

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    5d7e5af View commit details
    Browse the repository at this point in the history

  14. Merge branch 'generic-type-pretty' into try-method-match

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    570a03a View commit details
    Browse the repository at this point in the history

  15. Merge branch 'master' into generic-type-pretty

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    7cdb1b8 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'generic-type-pretty' into try-method-match

    @msridhar
    msridhar committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    a2dbade View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. tweaks

    @msridhar
    msridhar committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    608f3db View commit details
    Browse the repository at this point in the history

  2. cleanup

    @msridhar
    msridhar committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    39c6e7d View commit details
    Browse the repository at this point in the history

  3. more cleanup

    @msridhar
    msridhar committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    ac24db5 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @msridhar
    msridhar committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    eb1ecae View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2023

  1. docs

    @msridhar
    msridhar committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    3bbd1d6 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. more

    @msridhar
    msridhar committed May 6, 2023
    Configuration menu
    Copy the full SHA
    ee73b04 View commit details
    Browse the repository at this point in the history

  2. more

    @msridhar
    msridhar committed May 6, 2023
    Configuration menu
    Copy the full SHA
    e56cb12 View commit details
    Browse the repository at this point in the history

  3. more

    @msridhar
    msridhar committed May 6, 2023
    Configuration menu
    Copy the full SHA
    05782eb View commit details
    Browse the repository at this point in the history

  4. more

    @msridhar
    msridhar committed May 6, 2023
    Configuration menu
    Copy the full SHA
    90a4530 View commit details
    Browse the repository at this point in the history

  5. cleanup tests

    @msridhar
    msridhar committed May 6, 2023
    Configuration menu
    Copy the full SHA
    a769e30 View commit details
    Browse the repository at this point in the history

  6. another rename

    @msridhar
    msridhar committed May 6, 2023
    Configuration menu
    Copy the full SHA
    6630bbf View commit details
    Browse the repository at this point in the history

  7. WIP

    @msridhar
    msridhar committed May 6, 2023
    Configuration menu
    Copy the full SHA
    b33ff48 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2023

  1. more tests

    @msridhar
    msridhar committed May 7, 2023
    Configuration menu
    Copy the full SHA
    8500957 View commit details
    Browse the repository at this point in the history

  2. more

    @msridhar
    msridhar committed May 7, 2023
    Configuration menu
    Copy the full SHA
    250fb68 View commit details
    Browse the repository at this point in the history

  3. Make all methods in GenericsChecks static

    @msridhar
    msridhar committed May 7, 2023
    Configuration menu
    Copy the full SHA
    0593341 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'make-generics-checks-methods-static' into override-anon… 

    …ymous-class-checking
    @msridhar
    msridhar committed May 7, 2023
    Configuration menu
    Copy the full SHA
    68adca8 View commit details
    Browse the repository at this point in the history

  5. more, still need tests for conditional expressions as receivers

    @msridhar
    msridhar committed May 7, 2023
    Configuration menu
    Copy the full SHA
    1298081 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Merge branch 'master' into try-method-match

    @msridhar
    msridhar committed May 8, 2023
    Configuration menu
    Copy the full SHA
    fb3f418 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'try-method-match' into make-generics-checks-methods-static

    @msridhar
    msridhar committed May 8, 2023
    Configuration menu
    Copy the full SHA
    e2bd583 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'make-generics-checks-methods-static' into override-anon… 

    …ymous-class-checking
    @msridhar
    msridhar committed May 8, 2023
    Configuration menu
    Copy the full SHA
    40affd0 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. Merge branch 'master' into try-method-match

    @msridhar
    msridhar authored May 14, 2023
    Configuration menu
    Copy the full SHA
    564c8dc View commit details
    Browse the repository at this point in the history

  2. fix nullaway error

    @msridhar
    msridhar committed May 14, 2023
    Configuration menu
    Copy the full SHA
    662606a View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Merge branch 'master' into try-method-match

    @msridhar
    msridhar committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    3de870c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into try-method-match

    @msridhar
    msridhar authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    f7d8dc9 View commit details
    Browse the repository at this point in the history

  3. fix class ordering in test

    @msridhar
    msridhar committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    08596f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. bug fix: did not handle direct dereference of method call expression … 

    …with generic @nullable return type
    @msridhar
    msridhar committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    97ec62a View commit details
    Browse the repository at this point in the history

  2. test interactions with @contract

    @msridhar
    msridhar committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    8bca16e View commit details
    Browse the repository at this point in the history

  3. simplify using new API

    @msridhar
    msridhar committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    242b2e0 View commit details
    Browse the repository at this point in the history

  4. better variable names

    @msridhar
    msridhar committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    631c417 View commit details
    Browse the repository at this point in the history

  5. rename variables and add a TODO

    @msridhar
    msridhar committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    9024a67 View commit details
    Browse the repository at this point in the history

  6. add a comment

    @msridhar
    msridhar committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    be06ff1 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Merge branch 'try-method-match' into make-generics-checks-methods-static

    @msridhar
    msridhar committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    87d194a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'make-generics-checks-methods-static' into override-anon… 

    …ymous-class-checking
    @msridhar
    msridhar committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b364573 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Merge branch 'master' into try-method-match

    @msridhar
    msridhar committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    bb848fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'try-method-match' into make-generics-checks-methods-static

    @msridhar
    msridhar committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    55ac129 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'make-generics-checks-methods-static' into override-anon… 

    …ymous-class-checking
    @msridhar
    msridhar committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    58dcd9f View commit details
    Browse the repository at this point in the history

  4. bug fix

    @msridhar
    msridhar committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    1ad0952 View commit details
    Browse the repository at this point in the history

  5. delete unused method

    @msridhar
    msridhar committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    7333529 View commit details
    Browse the repository at this point in the history

  6. failing test

    @msridhar
    msridhar committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    09a2679 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. fixes

    @msridhar
    msridhar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    d0aa308 View commit details
    Browse the repository at this point in the history

  2. big simplification

    @msridhar
    msridhar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    12e78ea View commit details
    Browse the repository at this point in the history

  3. comments

    @msridhar
    msridhar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    2e36bde View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Merge branch 'master' into try-method-match

    @msridhar
    msridhar authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    83b82fb View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Merge branch 'master' into try-method-match

    @msridhar
    msridhar authored Jul 8, 2023
    Configuration menu
    Copy the full SHA
    bc3b181 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'try-method-match' into make-generics-checks-methods-static

    @msridhar
    msridhar committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    254c99a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'make-generics-checks-methods-static' into override-anon… 

    …ymous-class-checking
    @msridhar
    msridhar committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    fee899b View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Merge branch 'master' into try-method-match

    @msridhar
    msridhar authored Jul 15, 2023
    Configuration menu
    Copy the full SHA
    df25816 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Merge branch 'master' into try-method-match

    @msridhar
    msridhar authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    9582cff View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Merge branch 'master' into try-method-match

    @msridhar
    msridhar committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4afd3d9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'try-method-match' into make-generics-checks-methods-static

    @msridhar
    msridhar committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2e4a0e7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'make-generics-checks-methods-static' into override-anon… 

    …ymous-class-checking
    @msridhar
    msridhar committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    bb94132 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into try-method-match

    @msridhar
    msridhar authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    aa2bc8c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'try-method-match' into make-generics-checks-methods-static

    @msridhar
    msridhar committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    dc1c5fa View commit details
    Browse the repository at this point in the history

  6. Merge branch 'try-method-match' into override-anonymous-class-checking

    @msridhar
    msridhar committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4f6c05b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'make-generics-checks-methods-static' into override-anon… 

    …ymous-class-checking
    @msridhar
    msridhar committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2521dac View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Merge branch 'master' into make-generics-checks-methods-static

    @msridhar
    msridhar committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    eefe6e2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'make-generics-checks-methods-static' into override-anon… 

    …ymous-class-checking
    @msridhar
    msridhar committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    549146c View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2023

  1. add test case

    @msridhar
    msridhar committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    033b081 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Merge branch 'master' into override-anonymous-class-checking

    @msridhar
    msridhar committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    f7e0a87 View commit details
    Browse the repository at this point in the history

  2. fix comment

    @msridhar
    msridhar committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    f266006 View commit details
    Browse the repository at this point in the history

  3. exclude test

    @msridhar
    msridhar committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    9a981dc View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Merge branch 'master' into override-anonymous-class-checking

    @msridhar
    msridhar authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    3633f7b View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Merge branch 'master' into override-anonymous-class-checking

    @msridhar
    msridhar authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d1a50bf View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Merge branch 'master' into override-anonymous-class-checking

    @msridhar
    msridhar authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    cfdda5f View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Merge branch 'master' into override-anonymous-class-checking

    @msridhar
    msridhar authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    ef854c4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into override-anonymous-class-checking

    @msridhar
    msridhar committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    ed5a7bc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'override-anonymous-class-checking' of https://github.co… 

    …m/msridhar/NullAway into override-anonymous-class-checking
    @msridhar
    msridhar committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b6c7081 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Merge branch 'master' into override-anonymous-class-checking

    @msridhar
    msridhar authored Sep 1, 2023
    Configuration menu
    Copy the full SHA
    df4d0f7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into override-anonymous-class-checking

    @msridhar
    msridhar authored Sep 1, 2023
    Configuration menu
    Copy the full SHA
    bcc16c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Merge branch 'master' into override-anonymous-class-checking

    @msridhar
    msridhar authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    2721787 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Merge branch 'master' into override-anonymous-class-checking

    @msridhar
    msridhar authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    73255af View commit details
    Browse the repository at this point in the history

  2. test more cases

    @msridhar
    msridhar committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    778447e View commit details
    Browse the repository at this point in the history

  3. check that type is in fact a supertype

    @msridhar
    msridhar committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    af6ca1f View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. add tests

    @msridhar
    msridhar committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    16eb9c2 View commit details
    Browse the repository at this point in the history

  2. link issue and add static import

    @msridhar
    msridhar committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    26085c4 View commit details
    Browse the repository at this point in the history