Tests for loops over arrays

[msridhar]

We handle a loop with an index variable correctly, but not a for-each loop over an array, which needs to be fixed in a follow-up (see #983)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.90%. Comparing base (8593fe2) to head (0c7f34d).

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #982   +/-   ##
=========================================
  Coverage     85.90%   85.90%           
  Complexity     2066     2066           
=========================================
  Files            83       83           
  Lines          6854     6854           
  Branches       1320     1320           
=========================================
  Hits           5888     5888           
  Misses          550      550           
  Partials        416      416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lazaroclapp]

Interesting... wonder how we are representing the access paths here. Might be a bit much to ask (basically, you need NullAway to remember "we checked all elements of this array and they are all @NonNull, therefore..."

[msridhar]

Ah, maybe we should clarify this test. It's a bit confusing due to the multiple loops in the same method. This was just meant to test that if the array contents are @Nullable, the loop variable should be treated as @Nullable (which it currently isn't; that why the test is ignored). I wasn't thinking about using reasoning from the previous loop to avoid warning on the second warning.

@armughan11 when you work on #983, please rewrite this test to reorder the loops, to avoid this confusion