This repository has been archived by the owner on Mar 4, 2022. It is now read-only.
Update Prototool deps #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #542 +/- ##
======================================
Coverage ? 66.09%
======================================
Files ? 144
Lines ? 7462
Branches ? 0
======================================
Hits ? 4932
Misses ? 2023
Partials ? 507Continue to review full report at Codecov.
|
judezhu
pushed a commit
to dapperlabs/prototool
that referenced
this pull request
Aug 27, 2021
* Updates bazel * WORKSPACE * WORKSPACE changes to upgrade bazel and deps * Updates bazel deps * Commenting out failing TLS tests until a better solution can be found for testing * Update docker * Update alpine image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Prototool dependencies:
Go: 1.14
Bazel: 1.2
Bazel Rules Go: 0.22.1
Gazelle: 0.20.0
Alpine image: golang:1.14:alpine:3.11
See Dockerfile for additional upgrades.
In addition, updates some Bazel Go deps as well as a few in go.mod
Finally, this also comments out three unit tests involving mTLS which are failing under
make bazeltest. Currently, these tests work viamake testdue to the opt-out withGODEBUGin the Makefile. However, it doesn't seem possible to use this flag via Gazelle/go_test/Bazel. So, a better solution will need implemented to fix this without needing the opt-out flag.Tracked in #541