Search engine updates #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wesinator
commented
Oct 20, 2017
wesinator
commented
- Update URLs to HTTPS
- Fix broken Google search URL
- Update icons
vkareh
suggested changes
Oct 20, 2017
There was a problem hiding this comment.
It's looking good, but there are other instances of google.ico and wikipedia.ico used throughout the code that also need updating (or else the build fails)
Look inside applications.py (lines 911 and 918) as well as setup.py (lines 100 and 101).
Also, since you're at it, might as well change the ddg icon to a png as well ;)
vkareh
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.