Fix row:selected buttons

[Jupi007]

I'll do the patch for GTK4 inside the Libadwaita PR to avoid merging clash.

Closes #2847

[Feichtmeier]

Hm, I rather thought about a :not(.circular) selector to only change the radius of all other buttons, shouldnt this be enough?

[Jupi007]

Sorry I misunderstood your issue 😓
That I fixed here is the action button orange border and the dark icon on selected rows.
I didn't noticed the white outline...

In fact the buttons doesn't use the .circular selector but a .btn_circular, btw in the dev version, it looks like they moved to .circular: bottlesdevs/Bottles@4a2572d#diff-e144420ba74b5637b04111e3de9b54f8c9451a2c626eac32b946b9218bff9a34
That fix your issue :)

[Feichtmeier]

Oh okay 😊
It's still too much diff in common I think. Can't we somehow leave this in tweaks?

[Jupi007]

It's still too much diff in common I think. Can't we somehow leave this in tweaks?

The problem is that these lines overwrite the border of all widgets on row:selected. It is very simpler to comment them directly.
Move this to tweaks will need to re-overwrite the border to the default value. But I think it is the better solution if we want one day to drop some tweaks.

Well, stop complaining, I'll try to do this :)

[Feichtmeier]

Right, okay. Just keep in mind that it needs to stay maintainable. Feel free to merge when you are done

[Feichtmeier]

I mean, we could also move away from _tweaks completely. If we mark each yaru change in common.

[Jupi007]

I mean, we could also move away from _tweaks completely. If we mark each yaru change in common.

That could be simpler in some case but more complicated in other case.

Here we have the same problem as the inverted headerbar: if I want to re-overwrite the button border looks to default, I must restyle the whole button stack. So it's really better to just comment some lines in _common.

[Feichtmeier]

There are several things in _tweaks that are really just nitpicks in my opion and rarely seen in apps, maybe we could have a dedicated discussion on this topic, I would prefer for libadwaita to stop any yaru modifications except _colors.scss

[Jupi007]

There are several things in _tweaks that are really just nitpicks in my opion and rarely seen in apps, maybe we could have a dedicated discussion on this topic, I would prefer for libadwaita to stop any yaru modifications except _colors.scss

Okay 👍

About this PR, unless you really want to move the patch to _tweaks (but that will need to add a mammoth part of code), I think I'll merge this as it.

[Feichtmeier]

Yes, go for it

[Jupi007]

Btw this PR also fix switches in selected rows.

Closes #2849