Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn 3 #1625

Merged
merged 23 commits into from
Jun 28, 2022
Merged

Yarn 3 #1625

merged 23 commits into from
Jun 28, 2022

Conversation

zbeyens
Copy link
Member

@zbeyens zbeyens commented Jun 25, 2022

Description

  • yarn 3
  • cleaned up the root of the repo, deps
  • new workspace:examples
    • examples/src has shared code between examples
    • examples/apps are app examples (next, cra)
    • examples/apps/next will be used for local development
  • yarn codegen will generate sandpack files from examples/src to docs/docs/sandpack/files for single maintenance
  • docs
    • no longer use react-live for the demos: it was difficult to reproduce and hard to maintain
    • cleaned up the deps
    • now uses Sandpack, which is also used by React beta docs.
    • each example has a sandpack using the generated files
    • as it's using plate latest release, this is no longer used for local development

Overall, it solves the reproducibility issues of all the examples.

Fixes #1541
Fixes #1406
Fixes #1328

@zbeyens zbeyens requested a review from dylans as a code owner June 25, 2022 22:24
@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2022

⚠️ No Changeset found

Latest commit: 7b39b22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
plate ✅ Ready (Inspect) Visit Preview Jun 28, 2022 at 9:25PM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant