Implementing 'push_notifications_only' config :: Aws Only for now #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The inspection completed: 1 new issues |
|
Maybe a better name for the option would be push_notifications_no_poll |
|
@GuilhermeMoura1 I'm not sure if this would be a great idea, the point of the SQS queue was for the visibility timeout - since all subscribers are notified of the SNS message, it was a way to avoid having service workers from processing the same message concurrently. If you remove SQS, you'd need to handle that situation yourself. Is that intended? |
|
Hey Guys, We subscribe one endpoint of our backend to SNS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
With this i have tried to implement a configuration parameter that allow me to use the bundle and aws provider only with the SNS to push messages to my backend, without SQS.
I know that SNS have the maximum retention time of 1 hour for messages but this is ok for my use case.
I also want to make the bundle able to configure/atach a delivery policy to be able to configure 'notification_retries' and 'retry_timeout' but until now i do not know how to do it.
If someone can help would be nice. Until i am able to do this, ill manually configure the delivery policy in SNS dashboard.
Please let me now if you find some problem with my changes.
Thank you!