[ISSUE] Afwall fails to apply rules on some network changes

[Fry-kun]

Describe the bug
Afwall fails to apply rules on some network changes. This happens very often when leaving wifi area & switching to cell data only.
It's extremely disruptive, it's hard to even disable the rules to get the phone into a working state. The only thing that seems to work consistently is rebooting the phone altogether, which is not a good workaround.

It's worth noting that the failure and/or success notices sometimes pop up twice, indicating that there might be 2+ processes trying to do the same thing.
The progress indicator also behaves strangely when there's an error: instead of a steady climb of numbers (100..150..300..500..), it jumps up and down between single/double digits & triple digits (20..100..45..200..70..300..) (note: pulled these numbers out of thin air, just trying to describe the general behavior. Let me know if you need me to capture this madness on video or anything)

Firewall Logs
Several unrelated attempts logs.tar.gz

Smartphone (please complete the following information):

• Device: Pixel 6 Pro (raven)
• Android OS: 12

Additional context
This has been happening a lot lately (with this new phone, possibly because it's using 5G and/or whatever else?)

[ukanth]

Have you tried latest BETA ?

[Fry-kun]

I'm in beta program in the Play Store but there isn't one available yet...

…

On Thu, Jan 20, 2022, 19:39 robo-mo ***@***.***> wrote: Have you tried latest BETA ? — Reply to this email directly, view it on GitHub <#1262 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJIOEH3VG3XPR5XMU47GMDUXDINPANCNFSM5MNJUYBA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[ssivtsov]

Have the same behavior on OnePlus 9R, Android 11

[Fry-kun]

Hello?
Where/how do I access the beta? If I need to sideload it, where from?

[ukanth]

https://www.dropbox.com/s/f1fekfxpqmvw2mg/AFWall%2B_3.5.3_BETA1.apk?dl=0

[Fry-kun]

Thanks. Aside, a security app like a firewall shouldn't be distributed through a Dropbox link. Play store definitely supports beta distro, and though I haven't tried it, it shouldn't be too complicated to use. Don't know if you use Firebase, but it has some beta distribution features as well. F-Droid has very limited support, but supposedly it's also doable there. And of course GitHub actions could easily build the alphas/betas, see Magisk for example..

…

On Sun, Jan 23, 2022, 20:05 robo-mo ***@***.***> wrote: https://www.dropbox.com/s/f1fekfxpqmvw2mg/AFWall%2B_3.5.3_BETA1.apk?dl=0 — Reply to this email directly, view it on GitHub <#1262 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJIOEBPZ4V5G5PQPSPITUDUXTFXLANCNFSM5MNJUYBA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[Fry-kun]

With the beta, applying doesn't fail but I'm seeing this strange behavior

apply.mp4

Seems like the beta simply applies a lock which prevents 2 instances from updating at the same time. It's much better than not being able to apply the settings, but not a complete fix, IMHO

[ukanth]

Duplicate of #1206

#1206.

Read my last comment on that thread.

[DanielRieken]

With the beta, applying doesn't fail but I'm seeing this strange behavior
apply.mp4

Seems like the beta simply applies a lock which prevents 2 instances from updating at the same time. It's much better than not being able to apply the settings, but not a complete fix, IMHO

you're more than welcome to post a pull request, IMHO

[Fry-kun]

I have not actually read the code, this was just an observation, trying to help. I don't have the time right now for reading/updating this code; this is why I already donated toward development :P

…

On Thu, Jan 27, 2022, 15:09 DanielRieken ***@***.***> wrote: With the beta, applying doesn't fail but I'm seeing this strange behavior apply.mp4 Seems like the beta simply applies a lock which prevents 2 instances from updating at the same time. It's much better than not being able to apply the settings, but not a complete fix, IMHO you're more than welcome to post a pull request, IMHO — Reply to this email directly, view it on GitHub <#1262 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJIOEFUXP6DCB5FVTKTU5DUYHGEPANCNFSM5MNJUYBA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>