Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignore for git files #1099

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Conversation

NanoCode012
Copy link
Contributor

@NanoCode012 NanoCode012 commented Oct 8, 2020

Mentioned here: #918 (comment)

I checked the .git files on my computer on multiple clones. I saw that it was only 5-8MB, so I don't think it's worth losing the tracked history.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improvement to the Docker environment setup for YOLOv5.

📊 Key Changes

  • Commented out the line in .dockerignore that previously excluded the .git directory.

🎯 Purpose & Impact

  • Purpose: The change is likely intended to include the .git directory in the Docker build context.
  • Impact: Users building Docker images of YOLOv5 will now have access to the .git directory within the container, which could be useful for version control purposes and may assist with actions that require Git history or configuration.

@glenn-jocher
Copy link
Member

Looks good, I agree!

@glenn-jocher glenn-jocher merged commit 77940c3 into ultralytics:master Oct 8, 2020
@NanoCode012 NanoCode012 deleted the patch-1 branch October 8, 2020 13:55
burglarhobbit pushed a commit to burglarhobbit/yolov5 that referenced this pull request Jan 1, 2021
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants