Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange export input after checks #1118

Merged
merged 1 commit into from
Oct 11, 2020
Merged

Rearrange export input after checks #1118

merged 1 commit into from
Oct 11, 2020

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Oct 11, 2020

img size checks are warnings (with autocorrection) rather than errors, so current implementation allows improperly formed model inputs.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Refinement of input tensor initialization in models/export.py.

📊 Key Changes

  • Input tensor img creation moved after model load and img_size verification.
  • Removal of redundant tuple unpacking in input tensor shape.

🎯 Purpose & Impact

  • Ensures that the input tensor matches the model's expected input size, increasing robustness.
  • Simplifies the code for readability and potential performance benefits.
  • Users can expect more reliable model export functionality with updated input size checks. 🚀

img size checks are warnings rather than errors, so current implementation allows improperly formed model inputs.
@glenn-jocher glenn-jocher changed the title Rearrange input after checks Rearrange export input after checks Oct 11, 2020
@glenn-jocher
Copy link
Member Author

CI passing, merging.

@glenn-jocher glenn-jocher merged commit d45e349 into master Oct 11, 2020
@glenn-jocher glenn-jocher deleted the checks_rearrange branch October 11, 2020 14:23
glenn-jocher added a commit that referenced this pull request Oct 15, 2020
img size checks are warnings rather than errors, so current implementation allows improperly formed model inputs.
burglarhobbit pushed a commit to burglarhobbit/yolov5 that referenced this pull request Jan 1, 2021
img size checks are warnings rather than errors, so current implementation allows improperly formed model inputs.
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
img size checks are warnings rather than errors, so current implementation allows improperly formed model inputs.
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
img size checks are warnings rather than errors, so current implementation allows improperly formed model inputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant