Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #169

Closed
wants to merge 3 commits into from
Closed

Fix bugs #169

wants to merge 3 commits into from

Conversation

Lornatang
Copy link
Contributor

@Lornatang Lornatang commented Jun 22, 2020

fix TypeError: non_max_suppression() got an unexpected keyword argument 'fast'

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Introducing YOLOv4 configuration and updating dependencies for consistency.

📊 Key Changes

  • Updated non_max_suppression call in detect.py to use merge=True instead of fast=True.
  • Added yolov4.yaml file, defining the configuration for the YOLOv4 model.
  • Pinned specific versions for torch and torchvision in requirements.txt to ensure compatibility.

🎯 Purpose & Impact

  • The change in non-max suppression improves the accuracy of bounding box predictions by merging overlapping boxes 📦.
  • The new YOLOv4 model configuration enables users to train and use a more advanced, state-of-the-art model for object detection 🤖.
  • Specifying exact versions of torch and torchvision reduces issues due to API changes in these libraries, making the setup process more reliable for users 🔧.

@glenn-jocher
Copy link
Member

@Lornatang thanks! I can't merge this because of the dependency issues, we can't force 1.4.

I've pushed a fix for the detect.py bug though, thank you for noticing this!

@Lornatang
Copy link
Contributor Author

Ok.

@Lornatang Lornatang closed this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants