Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip_package_creation_second_attempt #3773

Merged
merged 20 commits into from
Jun 26, 2021

Conversation

SkalskiP
Copy link
Contributor

@SkalskiP SkalskiP commented Jun 25, 2021

draft of the second attempt of pip package creation

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

This PR refactors the YOLOv5 repository, focusing on code reorganization and cleanup.

πŸ“Š Key Changes

  • Changed CI workflow triggers to only master branch.
  • Removed commented out code in CI workflow.
  • Simplified shell usage for GitHub actions.
  • Streamlined test workflow using environment variables.
  • Moved files from utils and models to examples and yolov5 folders for better organization.
  • Updated import paths to reflect new file locations.
  • Added setup.py for package distribution.
  • Updated requirement versions and fixed scikit-learn dependency version.
  • Updated hubconf.py to reflect changes in file paths and updated import statements.

🎯 Purpose & Impact

  • πŸ”¨ Cleaner and more maintainable codebase: The reorganized structure makes the repository easier to navigate and contribute to.
  • βœ… Enhanced CI checks: Streamlined CI workflows should improve build and test times.
  • ⬆️ Updated dependencies: Keeping dependencies up-to-date reduces security risks and potential compatibility issues.
  • πŸ“¦ Package installation: The inclusion of setup.py means that YOLOv5 can now be packaged and distributed, potentially making it easier for users to install and use the software.
  • πŸ‘©β€πŸ’» Developers' adaptation: Developers may need to update their import statements and workflows due to restructured directories and changed file paths.

@SkalskiP SkalskiP merged commit 7721aa9 into master Jun 26, 2021
@SkalskiP SkalskiP deleted the pip_package_creation_second_attempt branch June 26, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant