Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow --dynamic when --half is passed #7669

Merged
merged 2 commits into from
May 2, 2022

Conversation

dmatos2012
Copy link
Contributor

@dmatos2012 dmatos2012 commented May 2, 2022

Hi,
Add this assertion when dynamic is given as well as the --half argument to avoid the error as mentioned in issue #7641.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced compatibility checks in YOLOv5 model export script.

📊 Key Changes

  • Added a new assertion to export.py that prevents using the --half precision flag in conjunction with the --dynamic flag during model export.

🎯 Purpose & Impact

  • Purpose: The update ensures that users do not attempt to export a model with incompatible flags that could lead to errors during the export process.
  • Impact: This change improves user experience by providing clear error messages, preventing potential confusion and frustration. It helps maintain the stability and reliability of the model export feature by enforcing correct usage patterns.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @dmatos2012, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify your PR is up-to-date with upstream/master. If your PR is behind upstream/master an automatic GitHub Actions merge may be attempted by writing /rebase in a new comment, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
# git checkout feature  # <--- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
  • ✅ Verify all Continuous Integration (CI) checks are passing.
  • ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

@glenn-jocher glenn-jocher changed the title disallow --dynamic when --half is given Disallow --dynamic when --half is passed May 2, 2022
@glenn-jocher glenn-jocher changed the title Disallow --dynamic when --half is passed Disallow --dynamic when --half is passed May 2, 2022
@glenn-jocher glenn-jocher linked an issue May 2, 2022 that may be closed by this pull request
2 tasks
@glenn-jocher glenn-jocher merged commit bff6e51 into ultralytics:master May 2, 2022
@glenn-jocher
Copy link
Member

@dmatos2012 PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐

tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
* disallow dynamic arg when half is given

* Update export.py

Co-authored-by: David Matos <david@track32.nl>
Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* disallow dynamic arg when half is given

* Update export.py

Co-authored-by: David Matos <david@track32.nl>
Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* disallow dynamic arg when half is given

* Update export.py

Co-authored-by: David Matos <david@track32.nl>
Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export to ONNX with --dynamic gives RunTimeError
2 participants