Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rise filter #150

Merged
merged 3 commits into from
Jan 27, 2016
Merged

Added rise filter #150

merged 3 commits into from
Jan 27, 2016

Conversation

raphaklaus
Copy link
Contributor

No description provided.

@raphaklaus
Copy link
Contributor Author

There's an another pull request for this situation (#140). Feel free to close if necessary. :)

@raphaklaus raphaklaus mentioned this pull request Jan 23, 2016
@una una mentioned this pull request Jan 23, 2016
@raphaklaus
Copy link
Contributor Author

Ok! Let me test it to see the diff.

@raphaklaus
Copy link
Contributor Author

Looks fine! I've just fixed the radial-gradient without background property, and elevated the saturate value a bit. 😄

@una
Copy link
Owner

una commented Jan 25, 2016

I'm not sure it needs so much saturation -- are you checking with the test page at http://localhost:3000/test/?

You first will need to add @import 'rise' to scss/cssgram.scss to get it on the list

@raphaklaus
Copy link
Contributor Author

My apologies! I didn't see the test site. Well, I think it's hard to achieve the exact same result of Instagram filter. I've tried with linear and radial gradient together and get pretty decent output. But I don't wanna extend this PR. I'm committing changes as you recommended above.

@una
Copy link
Owner

una commented Jan 27, 2016

Yeah you're definitely right -- but this looks great :) thank you for your time!

una added a commit that referenced this pull request Jan 27, 2016
@una una merged commit 9a50a46 into una:master Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants