feat: create-commandkit typescript template #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
twlite
requested changes
Feb 1, 2024
| }; | ||
|
|
||
| export const commands = { | ||
| init: { | ||
| npm: 'npm init -y', | ||
| yarn: 'yarn init -y; yarn config set nodeLinker node-modules', | ||
| yarn: 'yarn init -y; yarn config set nodeLinker node-modules; yarn set version stable', |
There was a problem hiding this comment.
Suggested change
| yarn: 'yarn init -y; yarn config set nodeLinker node-modules; yarn set version stable', | |
| yarn: 'yarn init -2; yarn config set nodeLinker node-modules;', |
There was a problem hiding this comment.
- Using
yarn init -2creates a bunch of useless files (some of them are created by create-commandkit), including a.pnp.cjsfile - Using
yarn init -y; yarn config set nodeLinker node-moduleswill not create the extra files and will work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a TypeScript template to
create-commandkit, allowing users to use TypeScript for their project instead of JavaScript.Preview
Other Changes
--noEmitflag to create-commandkit's lint script, for consistency and to ensure no files are emitted.