Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign in with different wallets popup #50

Merged
merged 3 commits into from
Apr 14, 2021
Merged

sign in with different wallets popup #50

merged 3 commits into from
Apr 14, 2021

Conversation

rymksotnini
Copy link
Collaborator

resolves #15

@@ -23,7 +38,7 @@
"react-dom": "^16.13.1",
"react-markdown": "^5.0.3",
"react-router-dom": "^5.1.2",
"react-scripts": "3.4.1",
"react-scripts": "^4.0.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up here? Please put back to 3.4.1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@tenthirtyone
Copy link
Collaborator

@rymksotnini
On startup, is there additional configuration change?:
image

@rymksotnini
Copy link
Collaborator Author

@rymksotnini
On startup, is there additional configuration change?:
image

When pushing I forgot that the .env is listed in the .gitignore. So just adding the .env file in client folder will resolve the problem

@tenthirtyone
Copy link
Collaborator

👍 Good job

Confirming using Injected method mimics existing behavior. I was able to launch/fulfill.

@rymksotnini @mehranhydary How should we test additional login methods? I'm thinking at least the Trezor. Maybe we can task the opensource devs with testing logging in and launching a bounty?

@rymksotnini because we have the opensource devs working on issues let's make the following updates before the merge:

  1. Update the README in the top-level repo with the client .env instructions.
  2. Add a .env.example to the client folder with empty values for the new env vars.

After we merge I'll let the slack channel know to update their forks and merge up and give them instructions to use Injected.

@tenthirtyone tenthirtyone merged commit df2ff44 into develop Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile: Signing in
2 participants