Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-13212 Torwali(trw) #121

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Conversation

Jalaluddin5641
Copy link
Contributor

@Jalaluddin5641 Jalaluddin5641 commented Aug 22, 2019

new file for torwali locale

Checklist
  • Issue filed: CLDR-13212
  • Updated PR title and link in previous line to include Issue number

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2019

CLA assistant check
All committers have signed the CLA.

@Jalaluddin5641
Copy link
Contributor Author

Thanks

@srl295
Copy link
Member

srl295 commented Aug 22, 2019

@Jalaluddin5641 so you can see our automated tests are starting to complain- follow this link

https://travis-ci.org/unicode-org/cldr/builds/575303908#L471

Error: (TestBasic.java:149) error: Attribute "draft" with value "confirmed" must have a value from the list "approved contributed provisional unconfirmed true false ".; SystemID: file:///home/travis/build/unicode-org/cldr/seed/main/trw.xml; PublicID: null; LineNumber: 28; ColumnNumber: 41
472

this is why I wanted a PR -so we can verify the content.

seed/main/trw.xml Outdated Show resolved Hide resolved
seed/main/trw.xml Outdated Show resolved Hide resolved
seed/main/trw.xml Outdated Show resolved Hide resolved
@Jalaluddin5641
Copy link
Contributor Author

there is already a file with name trw.xml in exampler/seed/main . this file needs to be deleted.

@srl295
Copy link
Member

srl295 commented Aug 28, 2019

@Jalaluddin5641 you should look at the existing file and compare it with yours. But, you need to delete it in your PR, effectively moving it out of exemplars and into seed.

@Jalaluddin5641
Copy link
Contributor Author

i tried to delete that file but i have no right to so.

seed/main/trw.xml Outdated Show resolved Hide resolved
@srl295
Copy link
Member

srl295 commented Aug 28, 2019

i tried to delete that file but i have no right to so.

  1. go to https://github.com/Jalaluddin5641/cldr/blob/patch-1/exemplars/main/trw.xml
  2. click the 🗑 (trash can) icon at the top right.

it will delete that file from your branch, which will update this PR.

@srl295
Copy link
Member

srl295 commented Aug 28, 2019

@Jalaluddin5641
Copy link
Contributor Author

Jalaluddin5641 commented Aug 28, 2019 via email

@Jalaluddin5641
Copy link
Contributor Author

Time and again same error " bad language code"

@srl295
Copy link
Member

srl295 commented Aug 28, 2019

Time and again same error " bad language code"

try merging Jalaluddin5641#1 if you like it

@Jalaluddin5641
Copy link
Contributor Author

Jalaluddin5641 commented Aug 29, 2019 via email

@srl295
Copy link
Member

srl295 commented Aug 29, 2019

see https://github.com/unicode-org/cldr/pull/78/files for another example:

<ldml>
 	<identity>
 		<version number="$Revision$"/>
 		<language type="trw"/>
 		<territory type="PK"/>
 	</identity>
 </ldml>
  • then, add language display name to trw.xml like so (but write it in Torwali)
	<localeDisplayNames>
 		<languages>
 			<language type="trw">TORWALI</language>
 		</languages>
 	</localeDisplayNames>

@Jalaluddin5641
Copy link
Contributor Author

Jalaluddin5641 commented Aug 29, 2019 via email

@srl295
Copy link
Member

srl295 commented Aug 29, 2019 via email

@Jalaluddin5641
Copy link
Contributor Author

Jalaluddin5641 commented Aug 29, 2019 via email

@srl295
Copy link
Member

srl295 commented Aug 29, 2019

@Jalaluddin5641
Copy link
Contributor Author

Hi dear.

@srl295
Copy link
Member

srl295 commented Sep 19, 2019

Hi dear.

Hi @Jalaluddin5641 — as I mentioned, we are near the end of the CLDR release cycle. This is some great work, including the name "توروالی" being added. But we can't progress this work for another month or two due to the CLDR schedule. Please don’t think that your work is being ignored.

Edit: I see that the travis build failures are cleared— excellent!!! I think this should not need a lot of work in order to go in. It may just take time, though.

@Jalaluddin5641
Copy link
Contributor Author

Jalaluddin5641 commented Sep 19, 2019 via email

@srl295
Copy link
Member

srl295 commented Nov 25, 2019

@Jalaluddin5641 hi, the tests are failing again - https://travis-ci.org/unicode-org/cldr/builds/587512159#L518

However the ticket is now accepted

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@Jalaluddin5641
Copy link
Contributor Author

HELLO

@Jalaluddin5641
Copy link
Contributor Author

@srl295 hi dear

@srl295
Copy link
Member

srl295 commented Jan 3, 2020

@Jalaluddin5641 I've identified someone who helped with torwali encoding who will help review this

@srl295
Copy link
Member

srl295 commented Feb 18, 2020

@Jalaluddin5641 I've identified someone who helped with torwali encoding who will help review this

I have heard back from an expert that your proposed exemplar is correct. Thanks!

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have heard from an expert that these are correct.

@srl295
Copy link
Member

srl295 commented Feb 18, 2020

@Jalaluddin5641 I have approved this and it will be merged as soon as the tree is open for CLDR 38. Thanks! I will contact you offline so you will be all set to contribute the rest of the data when the Survey Tool opens.

@srl295 srl295 merged commit 0c7f0d6 into unicode-org:master Mar 25, 2020
@srl295
Copy link
Member

srl295 commented Mar 25, 2020

@Jalaluddin5641 🎉

@Jalaluddin5641
Copy link
Contributor Author

What next i have to do?

@Jalaluddin5641
Copy link
Contributor Author

Thanks it was not possible without your help.

@srl295
Copy link
Member

srl295 commented Mar 25, 2020

What next i have to do?

This will show up in CLDR version 38. What I would do is, make sure you have a user account setup to contribute to trw. See http://cldr.unicode.org/index/survey-tool/accounts and click on the 'contact form' link. you can mention me… 

@srl295
Copy link
Member

srl295 commented May 26, 2020

@Jalaluddin5641 the Survey Tool is opening soon, do you have an account created for Torwali? See the link above.

@Jalaluddin5641
Copy link
Contributor Author

Jalaluddin5641 commented May 27, 2020 via email

@Jalaluddin5641
Copy link
Contributor Author

Jalaluddin5641 commented Jun 1, 2020 via email

@macchiati
Copy link
Member

macchiati commented Jun 1, 2020 via email

@srl295
Copy link
Member

srl295 commented Jun 1, 2020 via email

@Jalaluddin5641
Copy link
Contributor Author

Jalaluddin5641 commented Jun 5, 2020 via email

@srl295
Copy link
Member

srl295 commented Jun 5, 2020 via email

@Jalaluddin5641
Copy link
Contributor Author

Jalaluddin5641 commented Jun 7, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants