-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-13212 Torwali(trw) #121
Conversation
Thanks |
@Jalaluddin5641 so you can see our automated tests are starting to complain- follow this link https://travis-ci.org/unicode-org/cldr/builds/575303908#L471
this is why I wanted a PR -so we can verify the content. |
there is already a file with name trw.xml in exampler/seed/main . this file needs to be deleted. |
@Jalaluddin5641 you should look at the existing file and compare it with yours. But, you need to delete it in your PR, effectively moving it out of exemplars and into seed. |
i tried to delete that file but i have no right to so. |
it will delete that file from your branch, which will update this PR. |
the data in exemplars was: َ ُ ٔ آ أ {اَ}{اُ} {او}{اُو} ب پ ت ث ٹ ج چ ڇ ح خ څ د ذ ڈ ر ز ڑ ژ ڙ س ش ݜ ص-غ ف ق ک گ ل-ن ں ھ ہ و ی ے Your set is ء-أ ئ-ب پ ت ث ٹ ج چ ڇ ح خ څ ݲ د ذ ڈ ر ز ڑ ژ ڙ س ش ݜ ص-غ ف ق ک گ ل-ن ں ھ ہ ی ے It would be good to understand why these are different. |
great! let's see how the build works. it's at https://travis-ci.org/unicode-org/cldr/builds/577997413?utm_source=github_status&utm_medium=notification |
Time and again same error " bad language code" |
try merging Jalaluddin5641#1 if you like it |
Thanks alot. What next should i do?
…On Aug 29, 2019 12:44 AM, "Steven R. Loomis" ***@***.***> wrote:
Time and again same error " bad language code"
try merging Jalaluddin5641#1
<Jalaluddin5641#1> if you like it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#121?email_source=notifications&email_token=AGFFTJAXLIXX4RTU3OUNQ73QG3ITHA5CNFSM4IOUGOK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MIFNA#issuecomment-525894324>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGFFTJBND7YH6PCEXBQIN4TQG3ITHANCNFSM4IOUGOKQ>
.
|
see https://github.com/unicode-org/cldr/pull/78/files for another example:
<ldml>
<identity>
<version number="$Revision$"/>
<language type="trw"/>
<territory type="PK"/>
</identity>
</ldml>
<localeDisplayNames>
<languages>
<language type="trw">TORWALI</language>
</languages>
</localeDisplayNames> |
Where to add trw_PK?
…On Aug 29, 2019 11:36 PM, "Steven R. Loomis" ***@***.***> wrote:
see https://github.com/unicode-org/cldr/pull/78/files for another example:
-
need to figure out plurals. Do you know what the categories are? See
https://www.unicode.org/cldr/charts/34/supplemental/
language_plural_rules.html
<https://www.unicode.org/cldr/charts/34/supplemental/language_plural_rules.html>
- does Torwali have plural categories similar to Arabic, Urdu, Farsi, or
another language?
-
need a 'casing' file - this can be empty, so copy from
https://github.com/unicode-org/cldr/blob/master/common/casing/ar.xml
<https://github.com/unicode-org/cldr/blob/master/common/casing/ar.xml>
ar.xml (changing the language code inside) and add the file at
common/casing/trw.xml
-
add an empty trw_PK.xml file, this one will be like so
<ldml>
<identity>
<version number="$Revision$"/>
<language type="trw"/>
<territory type="PK"/>
</identity>
</ldml>
- then, add language display name to `trw.xml` like so (but write it in Torwali)
```xml
<localeDisplayNames>
<languages>
<language type="trw">TORWALI</language>
</languages>
</localeDisplayNames>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#121?email_source=notifications&email_token=AGFFTJAVZ6UPXOE3O552INTQHAJMBA5CNFSM4IOUGOK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5PNSJA#issuecomment-526309668>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGFFTJFKUDWM25VG6YCAZULQHAJMBANCNFSM4IOUGOKQ>
.
|
add trw_PK.xml in the same location as your original trw.xml
|
I should make a pull request?
…On Aug 30, 2019 12:22 AM, "Steven R. Loomis" ***@***.***> wrote:
add trw_PK.xml in the same location as your original trw.xml
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#121?email_source=notifications&email_token=AGFFTJACLWEZDRT2UMWRWH3QHAOX7A5CNFSM4IOUGOK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5PRQZQ#issuecomment-526325862>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGFFTJCRUH7OH26GXLI7SMLQHAOX7ANCNFSM4IOUGOKQ>
.
|
@Jalaluddin5641 no just go to https://github.com/Jalaluddin5641/cldr/tree/patch-1/seed/main and add the file |
Hi dear. |
Hi @Jalaluddin5641 — as I mentioned, we are near the end of the CLDR release cycle. This is some great work, including the name "توروالی" being added. But we can't progress this work for another month or two due to the CLDR schedule. Please don’t think that your work is being ignored. Edit: I see that the travis build failures are cleared— excellent!!! I think this should not need a lot of work in order to go in. It may just take time, though. |
I still want to continue my work no matter i will end this till next CLDR
cycle. Reason for delay is unavailbilty of internet for last 20 days.
…On Sep 19, 2019 11:25 PM, "Steven R. Loomis" ***@***.***> wrote:
Hi dear.
Hi @Jalaluddin5641 <https://github.com/Jalaluddin5641> — as I mentioned,
we are near the end of the CLDR release cycle. This is some great work,
including the name "توروالی" being added. But we can't progress this work
for another month or two due to the CLDR schedule. Please don’t think that
your work is being ignored.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#121?email_source=notifications&email_token=AGFFTJA7RKIWVLNHOGLGJZ3QKO7ZDA5CNFSM4IOUGOK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7EMQ5A#issuecomment-533252212>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGFFTJHFBYKWMO4LIA4IFD3QKO7ZDANCNFSM4IOUGOKQ>
.
|
@Jalaluddin5641 hi, the tests are failing again - https://travis-ci.org/unicode-org/cldr/builds/587512159#L518 However the ticket is now accepted |
f965b0d
to
cb2e276
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
HELLO |
@srl295 hi dear |
@Jalaluddin5641 I've identified someone who helped with torwali encoding who will help review this |
I have heard back from an expert that your proposed exemplar is correct. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have heard from an expert that these are correct.
@Jalaluddin5641 I have approved this and it will be merged as soon as the tree is open for CLDR 38. Thanks! I will contact you offline so you will be all set to contribute the rest of the data when the Survey Tool opens. |
What next i have to do? |
Thanks it was not possible without your help. |
This will show up in CLDR version 38. What I would do is, make sure you have a user account setup to contribute to |
@Jalaluddin5641 the Survey Tool is opening soon, do you have an account created for Torwali? See the link above. |
I already have a Survey Tool account at this e-mail address, and it is set
for the "trw" locale.
…On Mar 25, 2020 9:38 PM, "Steven R. Loomis" ***@***.***> wrote:
What next i have to do?
This will show up in CLDR version 38. What I would do is, make sure you
have a user account setup to contribute to trw. See
http://cldr.unicode.org/index/survey-tool/accounts and click on the
'contact form' link. you can mention me…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#121 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGFFTJF7LHS4MDGEKHMAQT3RJIXPXANCNFSM4IOUGOKQ>
.
|
How would I add torwali keyboard for different platform. Is it also a part
of this cycle.
…On May 27, 2020 7:44 PM, "Jalal Uddin" ***@***.***> wrote:
I already have a Survey Tool account at this e-mail address, and it is set
for the "trw" locale.
On Mar 25, 2020 9:38 PM, "Steven R. Loomis" ***@***.***>
wrote:
> What next i have to do?
>
> This will show up in CLDR version 38. What I would do is, make sure you
> have a user account setup to contribute to trw. See
> http://cldr.unicode.org/index/survey-tool/accounts and click on the
> 'contact form' link. you can mention me…
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#121 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGFFTJF7LHS4MDGEKHMAQT3RJIXPXANCNFSM4IOUGOKQ>
> .
>
|
The keyboard data is not part of the survey data; it uses tickets.
We need to get a pipeline developed fo processing that data however.
…On Mon, Jun 1, 2020, 05:46 Jalal Uddin ***@***.***> wrote:
How would I add torwali keyboard for different platform. Is it also a part
of this cycle.
On May 27, 2020 7:44 PM, "Jalal Uddin" ***@***.***> wrote:
> I already have a Survey Tool account at this e-mail address, and it is
set
> for the "trw" locale.
> On Mar 25, 2020 9:38 PM, "Steven R. Loomis" ***@***.***>
> wrote:
>
>> What next i have to do?
>>
>> This will show up in CLDR version 38. What I would do is, make sure you
>> have a user account setup to contribute to trw. See
>> http://cldr.unicode.org/index/survey-tool/accounts and click on the
>> 'contact form' link. you can mention me…
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#121 (comment)>,
>> or unsubscribe
>> <
https://github.com/notifications/unsubscribe-auth/AGFFTJF7LHS4MDGEKHMAQT3RJIXPXANCNFSM4IOUGOKQ
>
>> .
>>
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#121 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMHAEPEB5ECCWQCNOZTRUOPLTANCNFSM4IOUGOKQ>
.
|
Right. if you don’t already, please file a new issue for the keyboard ,and we can discuss that there.
|
Hi dear,
a character "و" is missing in examplers. What should i do now.i don't know
how i mistaken.
…On Jun 1, 2020 7:06 PM, "Steven R. Loomis" ***@***.***> wrote:
Right. if you don’t already, please file a new issue for the keyboard ,and
we can discuss that there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#121 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGFFTJH6TFHXQ2E4SRJICC3RUOYU7ANCNFSM4IOUGOKQ>
.
|
It looks like you already input data for https://st.unicode.org/cldr-apps/v#/trw/Alphabetic_Information/7ed88347aa1b55ed <https://st.unicode.org/cldr-apps/v#/trw/Alphabetic_Information/7ed88347aa1b55ed> - please just add the character there.
--
Steven R. Loomis | @srl295 | git.io/srl295
… El jun. 5, 2020, a las 8:15 a. m., Jalal Uddin ***@***.***> escribió:
Hi dear,
a character "و" is missing in examplers. What should i do now.i don't know
how i mistaken.
On Jun 1, 2020 7:06 PM, "Steven R. Loomis" ***@***.***> wrote:
> Right. if you don’t already, please file a new issue for the keyboard ,and
> we can discuss that there.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#121 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGFFTJH6TFHXQ2E4SRJICC3RUOYU7ANCNFSM4IOUGOKQ>
> .
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#121 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGQZM47TDB55YBR4KHL6HDRVED25ANCNFSM4IOUGOKQ>.
|
Hi dear,
i don"t see islamic calendar.majority of our people use islamic calander.
regards,
On Fri, Jun 5, 2020 at 8:30 AM Steven R. Loomis <notifications@github.com>
wrote:
… It looks like you already input data for
https://st.unicode.org/cldr-apps/v#/trw/Alphabetic_Information/7ed88347aa1b55ed
<
https://st.unicode.org/cldr-apps/v#/trw/Alphabetic_Information/7ed88347aa1b55ed>
- please just add the character there.
--
Steven R. Loomis | @srl295 | git.io/srl295
> El jun. 5, 2020, a las 8:15 a. m., Jalal Uddin ***@***.***>
escribió:
>
>
> Hi dear,
> a character "و" is missing in examplers. What should i do now.i don't
know
> how i mistaken.
> On Jun 1, 2020 7:06 PM, "Steven R. Loomis" ***@***.***>
wrote:
>
> > Right. if you don’t already, please file a new issue for the keyboard
,and
> > we can discuss that there.
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <#121 (comment)>,
or
> > unsubscribe
> > <
https://github.com/notifications/unsubscribe-auth/AGFFTJH6TFHXQ2E4SRJICC3RUOYU7ANCNFSM4IOUGOKQ
>
> > .
> >
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub <
#121 (comment)>, or
unsubscribe <
https://github.com/notifications/unsubscribe-auth/AAGQZM47TDB55YBR4KHL6HDRVED25ANCNFSM4IOUGOKQ
>.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#121 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGFFTJAJNO7XMBNKX35GFW3RVEFR5ANCNFSM4IOUGOKQ>
.
--
Cell NO. 03121332922
|
new file for torwali locale
Checklist