Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-11350 Added some clarifications on use of unitPatterns #403

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented Mar 24, 2020

Checklist

Added some info on unitPatterns in tr35-general that I hope is helpful, partly in addressing some of the issues raised in the JIRA ticket:

  1. Near the beginning of section 6 Unit Patterns, added:

The elements may be used to format quantities with decimal values; in such cases the choice of plural form will depend not only on the numeric value, but also on its formatting (see Language Plural Rules). In addition to formatting units for stand-alone use, elements are increasingly being used to format units for use in running text; for such usages, the new Grammatical Features information will be very useful.

Note that for certain plural cases, the unit pattern may not provide for inclusion of a numeric value—that is, it may not include “{0}”. This is especially true for the explicit cases “0” and “1” (which may have patterns like “zero seconds”). In certain languages such as Arabic and Hebrew, this may also be true with certain units for the plural cases “zero”, “one”, or “two” (in these languages, such plural cases are only used for the corresponding exact numeric values, so there is no concern about loss of precision without the numeric value).

  1. At the end of section 6.5 on Unicode Sequences:

In such sequences, decimal values are typically only used with the last element of the sequence, if at all.

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... Some small changes suggested

docs/ldml/tr35-general.html Outdated Show resolved Hide resolved
@pedberg-icu pedberg-icu force-pushed the CLDR-11350-clarifyUseOfUnitPatterns branch from 9dafdc6 to 559f89a Compare March 24, 2020 17:11
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@@ -2491,6 +2514,9 @@ <h3>6.<span class='changed'>5</span> <a name="Unit_Sequences" href="#Unit_Sequen
&lt;listPattern type="unit-narrow"&gt;
&lt;listPattern type="unit-short"&gt;
</pre>
<p class="changed">In such sequences, decimal values are typically only used with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was on my phone, and it somehow didn't record an additional comment.

Please change to:

In such as sequence, decimal fractions are typically only displayed for the last element of the sequence, if at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is better, thanks, made that change too

sffc
sffc previously approved these changes Mar 24, 2020
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pedberg-icu pedberg-icu force-pushed the CLDR-11350-clarifyUseOfUnitPatterns branch from 4f6b454 to 8f8f297 Compare March 24, 2020 18:49
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@pedberg-icu pedberg-icu merged commit 7ea30d1 into unicode-org:master Mar 24, 2020
@pedberg-icu pedberg-icu deleted the CLDR-11350-clarifyUseOfUnitPatterns branch March 24, 2020 20:17
pedberg-icu added a commit that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants