-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-11350 Added some clarifications on use of unitPatterns #403
CLDR-11350 Added some clarifications on use of unitPatterns #403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good... Some small changes suggested
9dafdc6
to
559f89a
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
docs/ldml/tr35-general.html
Outdated
@@ -2491,6 +2514,9 @@ <h3>6.<span class='changed'>5</span> <a name="Unit_Sequences" href="#Unit_Sequen | |||
<listPattern type="unit-narrow"> | |||
<listPattern type="unit-short"> | |||
</pre> | |||
<p class="changed">In such sequences, decimal values are typically only used with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was on my phone, and it somehow didn't record an additional comment.
Please change to:
In such as sequence, decimal fractions are typically only displayed for the last element of the sequence, if at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is better, thanks, made that change too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
4f6b454
to
8f8f297
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
(cherry picked from commit 7ea30d1)
Checklist
Added some info on unitPatterns in tr35-general that I hope is helpful, partly in addressing some of the issues raised in the JIRA ticket: