CLDR-13582 Make browser use most recent JavaScript files

[btangmu]

-Use the query string method like survey.js?v=5f1f23b

-Change INCLUDE_SCRIPT_VERSION to true in SurveyAjax.java

-Comments

Checklist

• Issue filed: https://unicode-org.atlassian.net/browse/CLDR-13582
• Updated PR title and link in previous line to include Issue number

[macchiati]

What happens if the script property is null or empty. Is the result what you want? If so, fine, but just checking.

[btangmu]

What happens if the script property is null or empty. Is the result what you want? If so, fine, but just checking.

Good question. CLDRConfig.getInstance().getProperty("CLDR_DIR_HASH") could return CLDRURLS.UNKNOWN_REVISION = "(unknown)" or null or empty string. (Let's assume those are all possible, to be safest.) The resulting queries would be "?v=(unknown)", "?v=null", and "?v=". I've just tested and confirmed that the JavaScript files are still loaded OK.

If CLDRConfig.getInstance() returned NULL we'd get a NullPointerException. That's true in many places where CLDRConfig.getInstance() is called.

I don't see a need for any change, do you?

[macchiati]

As long as the receiver discards the bogus values, np.

…

On Sun, Mar 29, 2020, 12:43 Tom Bishop ***@***.***> wrote: What happens if the script property is null or empty. Is the result what you want? If so, fine, but just checking. Good question. CLDRConfig.getInstance().getProperty("CLDR_DIR_HASH") could return CLDRURLS.UNKNOWN_REVISION = "(unknown)" or null or empty string. (Let's assume those are all possible, to be safest.) The resulting queries would be "?v=(unknown)", "?v=null", and "?v=". I've just tested and confirmed that the JavaScript files are still loaded OK. If CLDRConfig.getInstance() returned NULL we'd get a NullPointerException. That's true in many places where CLDRConfig.getInstance() is called. I don't see a need for any change, do you? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#406 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEME46UEBGZVURFYDRK3RJ6QH3ANCNFSM4LTWU6XQ> .

[btangmu]

As long as the receiver discards the bogus values, np.

Right. The query string (everything from "?" on) only affects caching of the JavaScript. The only harm that can result from bogus queries like "?v=null" is that the browser (or a proxy) might use an outdated cached version of the file longer than we want, just as is already the case now when there isn't any query string.

[macchiati]

ok, good. Mark

…

On Mon, Mar 30, 2020 at 7:23 AM Tom Bishop ***@***.***> wrote: As long as the receiver discards the bogus values, np. Right. The query string (everything from "?" on) only affects caching of the JavaScript. The only harm that can result from bogus queries like "?v=null" is that the browser (or a proxy) might use an outdated cached version of the file longer than we want, just as is already the case now when there isn't any query string. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#406 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMFNJNGVKT35F4KQS4DRKCTMJANCNFSM4LTWU6XQ> .