CLDR-13630 Fix verification chart for numbers #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refactored code and created test in the process of debugging. Actual fixes were:
|
|
the chart https://www.unicode.org/repos/cldr-aux/charts/37/verify/numbers/it.html shows fixed values. |
pedberg-icu
reviewed
Mar 29, 2020
|
|
||
| for (double source : allSamples) { | ||
| if (false && source == 22000000 && locale.equals("cs")) { | ||
| System.out.println("**"); |
There was a problem hiding this comment.
What is the problem with "cs" compact decimals? Is there a ticket?
There was a problem hiding this comment.
That's just debugging code. (there a bunch of that that could be cleaned up in various areas, but I'd rather not try to address in v37)
pedberg-icu
approved these changes
Mar 29, 2020
pedberg-icu
pushed a commit
that referenced
this pull request
Apr 1, 2020
(cherry picked from commit 8ff565b)
pedberg-icu
pushed a commit
that referenced
this pull request
Apr 16, 2020
(cherry picked from commit 8ff565b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist