Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-9326 show 'no items at this coverage level' in the sidebar #415

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Mar 30, 2020

CLDR-9326

The prior patch didn't take coverage into account.
This puts a static message in the sidebar when there's no coverage.

The prior patch didn't take coverage into account.
This puts a static message in the sidebar when there's no coverage.
@srl295 srl295 requested review from btangmu and Kristi27 March 30, 2020 22:08
@srl295 srl295 self-assigned this Mar 30, 2020
@srl295 srl295 requested a review from macchiati March 30, 2020 22:08
@srl295
Copy link
Member Author

srl295 commented Mar 30, 2020

Steps:

  1. go to any locale
  2. set coverage to Core
  3. bring up a category such as BCP47 or Currencies

Before: Chevron, empty content
nocovprefix

After: you get a message
nocovnoitem

@srl295 srl295 merged commit 90203b5 into unicode-org:master Apr 1, 2020
@srl295 srl295 deleted the T9326b branch April 1, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants