ICU-22357 Update gb18030 mappings for the -2022 version #2430
Conversation
|
Are we skipping the Plane 10 characters?
…On Sun, Apr 16, 2023 at 4:39 PM Peter Edberg ***@***.***> wrote:
Checklist
- Required: Issue filed:
https://unicode-org.atlassian.net/browse/ICU-22357
- Required: The PR title must be prefixed with a JIRA Issue number.
- Required: The PR description must include the link to the Jira
Issue, for example by completing the URL in the first checklist item
- Required: Each commit message must be prefixed with a JIRA Issue
number.
- Issue accepted (done by Technical Committee after discussion)
- Tests included, if applicable
- API docs and/or User Guide docs changed or added, if applicable
Update ICU gb18030 converter mappings from gb18030-2005 to gb18030-2022
(36 rearranged mappings). Two sets of updated mappings were near the
beginning or end of a range that was algorithmically mapped; in those cases
the range was shortened, and the mappings removed from the range (including
some that are not being changed) were converted to explicit mappings.
------------------------------
You can view, comment on, or merge this pull request online at:
#2430
Commit Summary
- 4c006ef
<4c006ef>
ICU-22357 Update gb18030 mappings for the -2022 version
File Changes
(3 files <https://github.com/unicode-org/icu/pull/2430/files>)
- *M* icu4c/source/common/ucnvmbcs.cpp
<https://github.com/unicode-org/icu/pull/2430/files#diff-3e45501d2addd1007260f001856c29ef7f0e9b8ed01b6af62ee78ff51b25eeed>
(4)
- *M* icu4c/source/data/mappings/gb18030.ucm
<https://github.com/unicode-org/icu/pull/2430/files#diff-addb141f111fcf26932f095f7ce841203389cbf368cc50b9047f6e097016a2bd>
(92)
- *M* icu4c/source/test/testdata/conversion.txt
<https://github.com/unicode-org/icu/pull/2430/files#diff-289cf17ea2c13e1fedddc3435f0038bf5aa36d7e4a8be7c2993f741c552ceaf6>
(50)
Patch Links:
- https://github.com/unicode-org/icu/pull/2430.patch
- https://github.com/unicode-org/icu/pull/2430.diff
—
Reply to this email directly, view it on GitHub
<#2430>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMCBEHK6QII2MH7SZADXBR7MJANCNFSM6AAAAAAXAODBGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
For this PR, yes. This PR is just about updating from the GB18030-2005 mappings that used PUA, per the first table in the "No PUA Requirement" section of Ken Lunde's document The GB 18030-2022 Standard. I believe that is all that is needed for compliance with GB18030-2022 implementation level 2, which is all that most vendors need to support. |
|
I will review this later this week when I have a bit more time. Out of curiosity: Did you make these changes manually, or did you revive my 2000-era tools? |
@markusicu I made them manually (they are pretty small and specific) |
There was a problem hiding this comment.
In order to be consistent with other conversion files, we should actually rename this file to gb18030-2022.ucm and set the alias in convrtrs.txt, but we can do that later in a different PR or even ticket.
There was a problem hiding this comment.
Will do in another PR for this ticket
|
I confirmed that the mappings 100% match those that are recommended in L2/23-003R, which are specified in its data file (PDF attachment). |
pedberg-icu
force-pushed
the
ICU-22357-update-gb18030-for-2022
branch
from
f1bc15e
to
9af22cc
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
@markusicu @FrankYFTang I think I made all of the requested updates (except renaming the file and updating convrtrs.txt accordingly, which will be in a separate PR). Please take a look, thanks much for the feedback. |
pedberg-icu
force-pushed
the
ICU-22357-update-gb18030-for-2022
branch
from
51a9ef6
to
c438261
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
@markusicu still waiting on review, thanks (to remove your "changes requested" block) |
Checklist
Update ICU gb18030 converter mappings from gb18030-2005 to gb18030-2022 (36 rearranged mappings). Two sets of updated mappings were near the beginning or end of a range that was algorithmically mapped; in those cases the range was shortened, and the mappings removed from the range (including some that are not being changed) were converted to explicit mappings.