ICU-12505 U_HAVE_STD_ATOMICS, reduce & simplify configure options. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
was #50 ? |
|
Sorry about #50 & #51, stupid mistakes with wrong ticket numbers in PR name, branch names & commit messages, and I couldn't see how to fix the PR once created. This PR is a first step towards eliminating all of the platform-specific atomic & mutex implementation code from ICU in favor of using only C++11 standard facilities. Portable! The C++ runtime library developers already have to deal with the platform issues, we shouldn't be doing it again in ICU code. The ICU platform code is messy, tricky, and in need of maintenance, esp. on Windows. Retracting the autoconf tests will give a warning shot that full C++11 atomics support is expected, and that soon there will be no configurable work-around if it's missing. |
srl295
approved these changes
Aug 14, 2018
sffc
pushed a commit
to sffc/icu
that referenced
this pull request
Sep 26, 2018
sffc
pushed a commit
to sffc/icu
that referenced
this pull request
Sep 26, 2018
sffc
pushed a commit
to sffc/icu
that referenced
this pull request
Sep 27, 2018
sffc
pushed a commit
to sffc/icu
that referenced
this pull request
Sep 27, 2018
sffc
pushed a commit
to sffc/icu
that referenced
this pull request
Sep 27, 2018
sffc
pushed a commit
to sffc/icu
that referenced
this pull request
Sep 27, 2018
hugovdm
added a commit
to hugovdm/icu
that referenced
this pull request
Sep 5, 2020
ICU-20941 Support Mixed Units in NumberFormatter when using usage()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist