Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-20043 Compile warning fix with improved portability. #78

Merged
merged 1 commit into from
Aug 24, 2018
Merged

ICU-20043 Compile warning fix with improved portability. #78

merged 1 commit into from
Aug 24, 2018

Conversation

aheninger
Copy link
Contributor

@aheninger aheninger commented Aug 24, 2018 •
edited by jefgen
Loading

Checklist

@jefgen
Copy link
Member

jefgen commented Aug 24, 2018

Thank you for fixing this @aheninger!

@aheninger aheninger requested a review from jefgen August 24, 2018 17:26
@aheninger
Copy link
Contributor Author

The previous fix of the printf compile warning for %ld introduced a compile warning with clang. Using the PRId64 macro instead of %lld should be portable.

jefgen
jefgen approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@jefgen jefgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@aheninger aheninger merged commit 1b201c8 into unicode-org:master Aug 24, 2018
@aheninger aheninger deleted the ICU-20043 branch August 24, 2018 17:59
sffc pushed a commit to sffc/icu that referenced this pull request Sep 26, 2018
@aheninger @sffc
ICU-20043 Compile warning fix with improved portability. (unicode-org#78
92967fb 
)
sffc pushed a commit to sffc/icu that referenced this pull request Sep 26, 2018
@aheninger @sffc
ICU-20043 Compile warning fix with improved portability. (unicode-org#78
c9648a4 
)
sffc pushed a commit to sffc/icu that referenced this pull request Sep 27, 2018
@aheninger @sffc
ICU-20043 Compile warning fix with improved portability. (unicode-org#78
c3b1c1b 
)
sffc pushed a commit to sffc/icu that referenced this pull request Sep 27, 2018
@aheninger @sffc
ICU-20043 Compile warning fix with improved portability. (unicode-org#78
9d7258f 
)
sffc pushed a commit to sffc/icu that referenced this pull request Sep 27, 2018
@aheninger @sffc
ICU-20043 Compile warning fix with improved portability. (unicode-org#78
84080fe 
)
sffc pushed a commit to sffc/icu that referenced this pull request Sep 27, 2018
@aheninger @sffc
ICU-20043 Compile warning fix with improved portability. (unicode-org#78
6e5a546 
)
sven-oly added a commit to sven-oly/icu that referenced this pull request Apr 26, 2022
@sven-oly
ICU-21998: Update directions for BRS task unicode-org#78
9f47710
sven-oly added a commit to sven-oly/icu that referenced this pull request Apr 26, 2022
@sven-oly
ICU-21998: Update directions for BRS task unicode-org#78. Fixing PR
e2af07d
sven-oly added a commit to sven-oly/icu that referenced this pull request Apr 27, 2022
@sven-oly
ICU-21998: Update directions for BRS task unicode-org#78
6bfab2f
sven-oly added a commit to sven-oly/icu that referenced this pull request Apr 27, 2022
@sven-oly
ICU-21998: Update directions for BRS task unicode-org#78
4987e99
sven-oly added a commit to sven-oly/icu that referenced this pull request Apr 28, 2022
@sven-oly
ICU-21959: Update directions for BRS task unicode-org#78
a2eff01
sven-oly added a commit to sven-oly/icu that referenced this pull request Apr 28, 2022
@sven-oly
ICU-21959: Update directions for BRS task unicode-org#78
01317e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefgen jefgen jefgen approved these changes

Assignees

@jefgen jefgen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aheninger @jefgen