ZeroCopyFrom simplification attempt #1257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Manishearth please add a link to the bug this is blocked on |
|
The original bug of this form is rust-lang/rust#85636 , we might need to file a new one. I'll do that once I have a reduced testcase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1255
This currently doesn't work because rustc is unable to satisfy the bound
for<'a> <Cow<'static, str> as Yokeable<'a>>::Output: ZeroCopyFrom<'a, std::string::String>.Leaving the PR open as a draft in case someone wants to poke at it further.