Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window is not defined on server rendered apps #401

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

brunolemos
Copy link
Member

@brunolemos brunolemos commented May 8, 2024

Fix #364
Fix #376

@koralajoie
Copy link

Any idea when this might be merged?

@akichim21
Copy link

@adeelraza @lucasbesen @ivoIturrieta
Could you merge this?

@mineraux
Copy link

mineraux commented Jun 5, 2024

Up on this fix. Is it possible to merge asap please ?
@adeelraza @lucasbesen @ivoIturrieta

@mineraux
Copy link

@adeelraza @ivoIturrieta Can we have some followup on this PR please ? This is quite blocking

@brunolemos brunolemos merged commit 721d6f4 into master Jun 25, 2024
4 checks passed
@adeelraza adeelraza deleted the fix/window-undefined branch June 26, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"window is not defined" in NextJS. window is not defined error with Remix 2.0
6 participants