Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds AllowedHostsAreRegex implementation #52

Merged
merged 5 commits into from
Mar 26, 2019
Merged

Adds AllowedHostsAreRegex implementation #52

merged 5 commits into from
Mar 26, 2019

Conversation

pzeinlinger
Copy link
Contributor

Implements functionality in backwards compatible fashion regarding issue #50.

unrolled
unrolled approved these changes Mar 25, 2019
View reviewed changes
Copy link
Owner

@unrolled unrolled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can you add AllowedHostsAreRegex: false to the "Default options" in the readme as well? Once that's done I'll merge this.

@pzeinlinger
Copy link
Contributor Author

Sure - done.
Sorry for missing that one. ;-)

@unrolled unrolled merged commit 6ec27b8 into unrolled:v1 Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unrolled unrolled unrolled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pzeinlinger @unrolled