Feature/deduce request information #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handles slashes embedded in URLs far more effectively - Fixes two potential panics I somehow never ran into before now - Forces caller to decide how to handle invalid URLs - maybe they're base URI requests, but maybe not....
Since IIIF no longer does this for us, the router has to. This has the major benefit that we actually only redirect when the request was for a legitimate ID to begin with.
- Changes settings to split up web base path from the hostname since hostname can now be inferred - Changes the demos to use /iiif since that's the default web path now
Also simplifies the setup by using minio since testing this is way too painful to set up with actual S3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27