Skip to content

Commit

Permalink
Use 'module' instead of 'configuration'
Browse files Browse the repository at this point in the history
The two are somewhat interchangeable in this context, but 'module' or 'root
module' seems a little more common.

Signed-off-by: Nic Cope <negz@rk0n.org>
  • Loading branch information
negz committed Mar 8, 2021
1 parent 338f31e commit 6165ee7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
7 changes: 3 additions & 4 deletions apis/workspace/v1alpha1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,9 @@ type KeyReference struct {

// WorkspaceParameters are the configurable fields of a Workspace.
type WorkspaceParameters struct {
// Configuration of this workspace; i.e. the path to the directory that
// contains the main.tf file of the Terraform configuration's root module.
// Can be a git repository, GCS bucket, or S3 bucket.
Configuration string `json:"configuration"`
// The root module of this workspace; i.e. the path to the directory that
// contains the main.tf file of the Terraform configuration.
Module string `json:"module"`

// Configuration variables.
// +optional
Expand Down
6 changes: 3 additions & 3 deletions package/crds/workspace.tf.crossplane.io_workspaces.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ spec:
forProvider:
description: WorkspaceParameters are the configurable fields of a Workspace.
properties:
configuration:
description: Configuration of this workspace; i.e. the path to the directory that contains the main.tf file of the Terraform configuration's root module. Can be a git repository, GCS bucket, or S3 bucket.
module:
description: The root module of this workspace; i.e. the path to the directory that contains the main.tf file of the Terraform configuration.
type: string
varFiles:
description: Files of configuration variables. Explicitly declared vars take precedence.
Expand Down Expand Up @@ -116,7 +116,7 @@ spec:
type: object
type: array
required:
- configuration
- module
type: object
providerConfigRef:
description: ProviderConfigReference specifies how the provider that will be used to create, observe, update, and delete this managed resource should be configured.
Expand Down

0 comments on commit 6165ee7

Please sign in to comment.