Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go1.21 and crossplane-runtime 1.15.1 #245

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Conversation

bobh66
Copy link
Collaborator

@bobh66 bobh66 commented Feb 27, 2024

Description of your changes

Update to use go1.21 and crossplane-runtime 1.15.1

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Deployed into a test cluster and verified that Workspace resources are created/reconciled/deleted successfully.

@ytsarev
Copy link
Member

ytsarev commented Mar 3, 2024

/test-examples="examples/workspace-inline-aws.yaml"

@bobh66 bobh66 force-pushed the go_1_21 branch 2 times, most recently from 28ba3a4 to c93ee3b Compare April 15, 2024 18:09
@ytsarev
Copy link
Member

ytsarev commented Apr 15, 2024

/test-examples="examples/workspace-inline-aws.yaml"

@ytsarev
Copy link
Member

ytsarev commented Apr 15, 2024

@bobh66 Looks like go mod tidy is required

https://github.com/upbound/provider-terraform/actions/runs/8694401581
image

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uptest failed

Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
@ytsarev
Copy link
Member

ytsarev commented Apr 15, 2024

/test-examples="examples/workspace-inline-aws.yaml"

1 similar comment
@bobh66
Copy link
Collaborator Author

bobh66 commented Apr 15, 2024

/test-examples="examples/workspace-inline-aws.yaml"

bobh66 and others added 4 commits April 15, 2024 15:56
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
@bobh66
Copy link
Collaborator Author

bobh66 commented Apr 15, 2024

/test-examples="examples/workspace-inline-aws.yaml"

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks for the updates!

@ytsarev ytsarev merged commit a4f2514 into upbound:main Apr 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants