Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build module and go version #272

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

bobh66
Copy link
Collaborator

@bobh66 bobh66 commented Jun 12, 2024

Description of your changes

Update the build module to crossplane/build and go to 1.22

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Basic sanity testing in a kind cluster

Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bobh66!

@negz
Copy link
Member

negz commented Jun 13, 2024

Oh - I missed the failing checks. They're happening because I renamed some targets in the new build submodule. You can add a commit like crossplane-contrib/provider-upjet-aws@f9f5576 to fix them (or update ci.yaml to use the new targets).

@bobh66 bobh66 force-pushed the update_build branch 2 times, most recently from 8079161 to 39c304a Compare June 13, 2024 14:15
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
@bobh66 bobh66 merged commit 8694162 into upbound:main Jun 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants