ERC20 and Mother e2e tests #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for contracts-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kwingram25
previously approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains tests for the remaining ERC20 messages and for the rendering of complex inputs with
mother.contractIt also includes a major update of Cypress and updates to fixtures and
contracts-nodebinary.There is a strange bug with the gas estimation of
mother.contractwhich happens only in the testing environment . The gas limit is too low so the instantiation fails. When trying to increase the gas limit manually with Cypress, the app throws a blanc screen. Might happen because the test runner has limited resources. I skipped the instantiation tests so far formother.contractExtra:
Removed
@types/react-router- they are bundled with the package now and were causing build to failThe app now displays number inputs for all numeric types