Implement cross-contract testing in E2E framework #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executed for `substrate-contracts-node` v0.21.0:
cargo install subxt-cli
subxt metadata > contracts-node.scale
Same issue as use-ink/cargo-contract#777.
cmichi
force-pushed
the
cmichi-e2e-cross-contract-oct-08
branch
from
3acea90
to
66f5d2d
Compare
I had to remove `skip_build` as keeping it work would become too complex right now. Will create a follow-up ticket for it.
Codecov Report
@@ Coverage Diff @@
## master #1432 +/- ##
==========================================
- Coverage 70.89% 70.63% -0.27%
==========================================
Files 193 194 +1
Lines 6071 6095 +24
==========================================
+ Hits 4304 4305 +1
- Misses 1767 1790 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ascjones
reviewed
Oct 17, 2022
| .args([ | ||
| "+stable", | ||
| "contract", | ||
| "build", |
There was a problem hiding this comment.
Since we control cargo-contract it might be really nice to have a lib to allow invocation of contract builds...would certainly simplify the code here.
Made a quick start on it here use-ink/cargo-contract#787.
If you agree it is a good idea I can complete that.
There was a problem hiding this comment.
I agree it's a good idea!
athei
approved these changes
Oct 19, 2022
ascjones
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #1234.
Can be reviewed commit-by-commit, though the PR is also not that big in total.