Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration away from GitLab to GitHub Actions - stages lint, check #1948

Closed
wants to merge 22 commits into from

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Oct 25, 2023

Summary

Closes #

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependant on the specific version of cargo-contract or pallet-contracts?
    Migration away from GitLab to GitHub Actions - stages lint, check

Description

Implemented stages: lint, check, and the building part of the workspace stage.

Checklist before requesting a review

  • [y] My code follows the style guidelines of this project
  • [n] I have added an entry to CHANGELOG.md
  • [y] I have commented my code, particularly in hard-to-understand areas
  • [n] I have added tests that prove my fix is effective or that my feature works
  • [y] Any dependent changes have been merged and published in downstream modules

strategy:
fail-fast: false
steps:
- name: Rust Info
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code duplication. The option is to create a composite action/custom action or to avoid printing the Rust Info for all the jobs.

@paritytech-cicd-pr
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

⚠️ The ink! master is ahead of your branch, this might skew the comparison data below. ⚠️
These are the results when building the integration-tests/* contracts from this branch with cargo-contract 4.0.0-alpha-acc02b1 and comparing them to ink! master:

Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
basic-contract-caller 2.998 2.998 0 0
basic-contract-caller/other-contract 1.338 1.338 0 0
call-builder-return-value 8.74 8.74 0 0
call-runtime 1.774 1.774 0 0
conditional-compilation 1.21 1.21 0 0
contract-storage 7.142 7.142 0 0
contract-terminate 1.092 1.092 0 0
contract-transfer 1.449 1.449 0 0
custom-allocator 7.429 7.429 0 0
dns 7.313 7.313 0 0
e2e-call-runtime 1.062 1.062 0 0
e2e-runtime-only-backend 1.64 1.64 0 0
erc1155 14.119 14.125 0.006 0.0424959 📈
erc20 6.729 6.729 0 0
erc721 9.716 9.716 0 0
events 4.823 4.823 0 0
flipper 1.394 1.394 0 0
incrementer 1.223 1.223 0 0
lang-err-integration-tests/call-builder-delegate 2.327 2.327 0 0
lang-err-integration-tests/call-builder 4.88 4.88 0 0
lang-err-integration-tests/constructors-return-value 1.783 1.783 0 0
lang-err-integration-tests/contract-ref 4.363 4.363 0 0
lang-err-integration-tests/integration-flipper 1.572 1.572 0 0
mapping-integration-tests 3.216 3.216 0 0
mother 9.555 9.555 0 0
multi-contract-caller 5.993 5.993 0 0
multi-contract-caller/accumulator 1.096 1.096 0 0
multi-contract-caller/adder 1.672 1.672 0 0
multi-contract-caller/subber 1.693 1.693 0 0
multisig 21.628 21.628 0 0
payment-channel 5.559 5.559 0 0
sr25519-verification 0.87 0.87 0 0
static-buffer 1.418 1.418 0 0
trait-dyn-cross-contract-calls 2.491 2.491 0 0
trait-dyn-cross-contract-calls/contracts/incrementer 1.306 1.306 0 0
trait-erc20 7.113 7.113 0 0
trait-flipper 1.21 1.21 0 0
trait-incrementer 1.371 1.371 0 0
upgradeable-contracts/delegator 2.914 2.914 0 0
upgradeable-contracts/delegator/delegatee 1.374 1.374 0 0
upgradeable-contracts/set-code-hash 1.466 1.466 0 0
upgradeable-contracts/set-code-hash/updated-incrementer 1.445 1.445 0 0
wildcard-selector 2.625 2.625 0 0

Link to the run | Last update: Wed Oct 25 14:06:53 CEST 2023

@smiasojed smiasojed closed this Oct 25, 2023
@paritytech-cicd-pr
Copy link

This is a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants