-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: separate different types of builders into different files #2228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog update plz. And could you check if change to ink-docs
are necessary?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2228 +/- ##
==========================================
- Coverage 60.58% 60.55% -0.03%
==========================================
Files 140 141 +1
Lines 5779 5773 -6
Branches 2448 2448
==========================================
- Hits 3501 3496 -5
+ Misses 2278 2277 -1 ☔ View full report in Codecov by Sentry. |
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Tue Apr 30 17:25:17 CEST 2024 |
This is an internal refactoring, the external API remains unchanged so I believe no changelog entry or docs required. |
A step towards providing the call builder style API for calling contracts from pallets, following up on #2219 as part of #1674.
This also separates the
CallFlags
from theCallBuilder
(since call flags are not used when calling intopallet_contracts
directly)