Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4.3 devel tools on traditional clients #1733

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented Oct 8, 2024

What does this PR change?

This PR declares 4.3 devel tools on traditional clients, in addition to the devel tools shared with 5.0

Copy link
Contributor

@maximenoel8 maximenoel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, we will have both 4.3 and 5.0 tool repo for the clients.

salt/repos/client_tools.sls Show resolved Hide resolved
salt/repos/client_tools.sls Show resolved Hide resolved
@maximenoel8
Copy link
Contributor

maximenoel8 commented Oct 8, 2024

This file is really complex... What about splitting it into product version files in a folder and having a clienttools.sls calling those files depending on the product version ? So we will have only condition in those product version files depending on the client type and we avoid those super nested conditions.
This three to four levels of conditions will trigger rubocop :-p.

@Bischoff
Copy link
Contributor Author

Bischoff commented Oct 8, 2024

This file is really complex... What about splitting it into product version files in a folder and having a clienttools.sls calling those files depending on the product version ? So we will have only condition in those product version files depending on the client type and we avoid those super nested conditions. This three to four level of conditions will trigger rubocop :-p.

Great minds meet each other: https://github.com/SUSE/spacewalk/issues/25438

@Bischoff
Copy link
Contributor Author

Bischoff commented Oct 8, 2024

For me, we will have both 4.3 and 5.0 tool repo for the clients.

For traditional, yes. See https://suse.slack.com/archives/C02DDLYLFMX/p1728389516609459

@Bischoff Bischoff merged commit 405a61e into uyuni-project:master Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants