Skip to content

Commit

Permalink
doc: consolidate test/lint text in GH PR template
Browse files Browse the repository at this point in the history
PR-URL: nodejs#7155
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and julianduque committed Jun 7, 2016
1 parent 101bda1 commit 0155744
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
<!--
Thank you for your pull request. Please review below requirements.
Run tests with `make -j4 test` on UNIX or `vcbuild test nosign` on Windows.
If this aims to fix a regression or you’re adding a feature, make sure you also
write a test. If possible, include a benchmark that quantifies your changes.
Expand All @@ -13,7 +11,7 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [ ] tests and code linting passes
- [ ] `make -j4 test` (UNIX) or `vcbuild test nosign` (Windows) passes
- [ ] a test and/or benchmark is included
- [ ] documentation is changed or added
- [ ] the commit message follows commit guidelines
Expand Down

0 comments on commit 0155744

Please sign in to comment.