Skip to content

Commit

Permalink
doc: edit pull request template
Browse files Browse the repository at this point in the history
Move checklist instructions closer to the checklist. Trim unnecessary
words.

PR-URL: nodejs#7058
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
  • Loading branch information
Trott committed Jun 2, 2016
1 parent 85da963 commit e350deb
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
<!--
Thank you for your pull request. Please review below requirements and walk
through the checklist. You can 'tick' a box by using the letter "x": [x].
Thank you for your pull request. Please review below requirements.
Run the test suite with: `make -j4 test` on UNIX or `vcbuild test nosign` on
Windows.
Run tests with `make -j4 test` on UNIX or `vcbuild test nosign` on Windows.
If this aims to fix a regression or you’re adding a feature, make sure you also
write a test. If possible, include a benchmark that quantifies your changes.
Expand All @@ -13,7 +11,7 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
-->

##### Checklist
<!-- remove lines that do not apply to you -->
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [ ] tests and code linting passes
- [ ] a test and/or benchmark is included
Expand Down

0 comments on commit e350deb

Please sign in to comment.