Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HMR for translation files (#20142) (CP: 24.5) #20153

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

* fix: HMR for translation files

* Clears resource bundle cache on translation resource redeployment
* Fires a HMR event to the browser when translations are reloaded

Limitation: Only supports DefaultI18NHandler where the paths are known. If you have a custom I18N handler, you might need a custom HMR supporting HotswapListener.

For #20118
Requires vaadin/hilla#2795 to fully fix the issue

* format

* trigger Flow UIs refresh

* flow support

* detect correct refresh stragety per UI

---------

Co-authored-by: Marco Collovati <marco@vaadin.com>
Copy link

github-actions bot commented Oct 7, 2024

Test Results

1 140 files  ± 0  1 140 suites  ±0   1h 11m 48s ⏱️ +56s
7 420 tests ± 0  7 370 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 763 runs   - 27  7 705 ✅  - 25  58 💤  - 2  0 ❌ ±0 

Results for commit f13ffcd. ± Comparison against base commit 8d0e36c.

Copy link

sonarcloud bot commented Oct 7, 2024

@mshabarov mshabarov merged commit 47a58ac into 24.5 Oct 7, 2024
26 checks passed
@mshabarov mshabarov deleted the cherry-pick-20142-to-24.5-1728289626629 branch October 7, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants