Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve route parameters when rerouting and forwarding with query parameters #20210

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: resolve route parameters when rerouting and forwarding with query parameters #20210

merged 1 commit into from
Oct 10, 2024

Conversation

mcollovati
Copy link
Collaborator

Fixes #20205

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Test Results

1 142 files  + 1  1 142 suites  +1   1h 29m 26s ⏱️ + 4m 16s
7 454 tests + 7  7 404 ✅ + 7  50 💤 ±0  0 ❌ ±0 
7 811 runs  +27  7 751 ✅ +27  60 💤 ±0  0 ❌ ±0 

Results for commit 56cc455. ± Comparison against base commit 2d42aad.

This pull request removes 1 and adds 8 tests. Note that renamed tests count towards both. 
com.vaadin.flow.uitest.ui.SetParameterForwardToIT ‑ testForwardingToViewInSetParameter[any_Chrome_]

com.vaadin.flow.uitest.ui.SetParameterForwardToIT ‑ testForwardingToViewWithLocation_setParameter[any_Chrome_]
com.vaadin.flow.uitest.ui.SetParameterForwardToIT ‑ testForwardingToViewWithQueryParameter_setParameter[any_Chrome_]
com.vaadin.flow.uitest.ui.SetParameterForwardToIT ‑ testForwardingToViewWithRouteParameterList_setParameter[any_Chrome_]
com.vaadin.flow.uitest.ui.SetParameterForwardToIT ‑ testForwardingToViewWithRouteParameter_setParameter[any_Chrome_]
com.vaadin.flow.uitest.ui.SetParameterRerouteToIT ‑ testReroutingToViewWithLocation_setParameter[any_Chrome_]
com.vaadin.flow.uitest.ui.SetParameterRerouteToIT ‑ testReroutingToViewWithQueryParameter_setParameter[any_Chrome_]
com.vaadin.flow.uitest.ui.SetParameterRerouteToIT ‑ testReroutingToViewWithRouteParameterList_setParameter[any_Chrome_]
com.vaadin.flow.uitest.ui.SetParameterRerouteToIT ‑ testReroutingToViewWithRouteParameter_setParameter[any_Chrome_]

@mcollovati mcollovati merged commit 9bc6d70 into main Oct 10, 2024
26 checks passed
@mcollovati mcollovati deleted the issues/20205-forward_quary_parameters_missing_route_param branch October 10, 2024 13:53
vaadin-bot pushed a commit that referenced this pull request Oct 10, 2024
@mcollovati @vaadin-bot
fix: resolve route parameters when rerouting and forwardin with query…
c0383ef 
… parameters (#20210)

Fixes #20205
vaadin-bot pushed a commit that referenced this pull request Oct 10, 2024
@mcollovati @vaadin-bot
fix: resolve route parameters when rerouting and forwardin with query…
f4a6ffc 
… parameters (#20210)

Fixes #20205
vaadin-bot pushed a commit that referenced this pull request Oct 10, 2024
@mcollovati @vaadin-bot
fix: resolve route parameters when rerouting and forwardin with query…
7863e87 
… parameters (#20210)

Fixes #20205
vaadin-bot pushed a commit that referenced this pull request Oct 10, 2024
@mcollovati @vaadin-bot
fix: resolve route parameters when rerouting and forwardin with query…
278480d 
… parameters (#20210)

Fixes #20205
vaadin-bot added a commit that referenced this pull request Oct 10, 2024
@vaadin-bot @mcollovati
fix: resolve route parameters when rerouting and forwardin with query…
0d28da4 
… parameters (#20210) (#20221)

Fixes #20205

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Oct 10, 2024
@vaadin-bot @mcollovati
fix: resolve route parameters when rerouting and forwardin with query…
3d29dc2 
… parameters (#20210) (#20220)

Fixes #20205

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Oct 10, 2024
@vaadin-bot @mcollovati
fix: resolve route parameters when rerouting and forwarding with quer…
e7a9b0a 
…y parameters (#20210) (CP: 24.3) (#20223)

* fix: resolve route parameters when rerouting and forwardin with query parameters (#20210)

Fixes #20205

* format code

---------

Co-authored-by: Marco Collovati <marco@vaadin.com>
mcollovati pushed a commit that referenced this pull request Oct 10, 2024
@vaadin-bot
fix: resolve route parameters when rerouting and forwarding with quer…
45d0bca 
…y parameters (#20210) (CP: 23.5) (#20222)

Fixes #20205
mshabarov pushed a commit that referenced this pull request Oct 16, 2024
@vaadin-bot @mshabarov
fix: resolve route parameters when rerouting and forwarding with quer…
0f2bf75 
…y parameters (#20210) (CP: 23.5) (#20222)

Fixes #20205
mshabarov pushed a commit that referenced this pull request Oct 16, 2024
@vaadin-bot @mshabarov
fix: resolve route parameters when rerouting and forwarding with quer…
130e6ff 
…y parameters (#20210) (CP: 23.5) (#20222)

Fixes #20205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tepi tepi tepi approved these changes

Assignees
No one assigned
Labels
cherry-picked-23.5 cherry-picked-24.3 cherry-picked-24.4 cherry-picked-24.5 target/23.5 target/24.3 target/24.4 target/24.5 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required URL/route parameter set to null when using BeforeEnterEvent.forwardTo()
3 participants
@mcollovati @tepi @vaadin-bot