-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add usage stats for dynamic menu entries #20212
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other PR related to statistics sets entry name in Constants
class, and it also has a has-xxxx
format.
Is it a convention to have flow/xxx
instead of has-xxxx
for Flow stats?
No, I created this first without any guidelines with naming. Other PR has already existing naming pattern to follow. However, we have other similar patterns with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I wonder if we should in the future do a little refactor and group all statistic constants in a dedicated class.
Fixes: #20209