Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add usage stats for dynamic menu entries #20212

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

tltv
Copy link
Member

@tltv tltv commented Oct 10, 2024

Fixes: #20209

Copy link

sonarcloud bot commented Oct 10, 2024

Copy link

Test Results

1 141 files  ± 0  1 141 suites  ±0   1h 26m 14s ⏱️ + 1m 4s
7 447 tests ± 0  7 397 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 808 runs  +24  7 748 ✅ +24  60 💤 ±0  0 ❌ ±0 

Results for commit f05575f. ± Comparison against base commit 2d42aad.

@tltv tltv marked this pull request as draft October 10, 2024 11:39
@tltv tltv marked this pull request as ready for review October 10, 2024 14:00
Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other PR related to statistics sets entry name in Constants class, and it also has a has-xxxx format.
Is it a convention to have flow/xxx instead of has-xxxx for Flow stats?

@tltv
Copy link
Member Author

tltv commented Oct 11, 2024

The other PR related to statistics sets entry name in Constants class, and it also has a has-xxxx format. Is it a convention to have flow/xxx instead of has-xxxx for Flow stats?

No, I created this first without any guidelines with naming. Other PR has already existing naming pattern to follow. However, we have other similar patterns with flow/ in Constants. Point is to be clear it's Flow feature. I considered first to use flow/MenuConfiguration, but as this should mark menu entry usage only, not whole class, then flow/dynamic-menu-entries feels better.

Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I wonder if we should in the future do a little refactor and group all statistic constants in a dedicated class.

@tltv tltv merged commit cc926d5 into main Oct 11, 2024
26 checks passed
@tltv tltv deleted the fix/add-usagestats-menu-configuration branch October 11, 2024 11:50
vaadin-bot pushed a commit that referenced this pull request Oct 11, 2024
vaadin-bot added a commit that referenced this pull request Oct 11, 2024
Fixes: #20209

Co-authored-by: Tomi Virtanen <tltv@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add usage stats for dynamic menu entries feature in Flow
3 participants