Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct route path for MenuEntry #20235

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: correct route path for MenuEntry #20235

merged 1 commit into from
Oct 14, 2024

Conversation

tltv
Copy link
Member

@tltv tltv commented Oct 11, 2024

MenuEntry should not have route parameters included in the path for client routes. It should omit route path in same way as with Hilla automatic menu. Menu should not include nested routes for excluded menu item or for route with required parameter.

MenuEntry should not have route parameters included in the path for client routes. It should omit route path in same way as with Hilla automatic menu.
Menu should not include nested routes for excluded menu item or for route with required parameter.
Copy link

sonarcloud bot commented Oct 11, 2024

Copy link

Test Results

1 142 files  ± 0  1 142 suites  ±0   1h 26m 29s ⏱️ -44s
7 459 tests ± 0  7 409 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 781 runs   - 47  7 721 ✅  - 47  60 💤 ±0  0 ❌ ±0 

Results for commit a006792. ± Comparison against base commit 4924daa.

Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change break Hilla?
I feel the filtering should be in MenuConfiguration and not in MenuRegistry as at the moment registry returns what Hilla is expecting.

@tltv
Copy link
Member Author

tltv commented Oct 14, 2024

Does this change break Hilla?
I feel the filtering should be in MenuConfiguration and not in MenuRegistry as at the moment registry returns what Hilla is expecting.

It doesn't because Hilla uses collectClientMenuItems(...). This change affects only collectMenuItems() and collectMenuItemsList().

@tltv tltv merged commit 7796cd8 into main Oct 14, 2024
26 checks passed
@tltv tltv deleted the fix/menu-entry-path branch October 14, 2024 09:20
vaadin-bot pushed a commit that referenced this pull request Oct 14, 2024
MenuEntry should not have route parameters included in the path for client routes. It should omit route path in same way as with Hilla automatic menu.
Menu should not include nested routes for excluded menu item or for route with required parameter.
vaadin-bot added a commit that referenced this pull request Oct 14, 2024
MenuEntry should not have route parameters included in the path for client routes. It should omit route path in same way as with Hilla automatic menu.
Menu should not include nested routes for excluded menu item or for route with required parameter.

Co-authored-by: Tomi Virtanen <tltv@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants