Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for query parameters to AnchorTester. #1812

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Added support for query parameters to AnchorTester. #1812

merged 2 commits into from
Aug 12, 2024

Conversation

joelpop
Copy link
Collaborator

@joelpop joelpop commented Jul 8, 2024

Description

Added support for query parameters to AnchorTester.

Fixes #1811

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@joelpop joelpop added the UITest JUnit testing the UI label Jul 8, 2024
@joelpop joelpop requested a review from mcollovati July 8, 2024 23:14
@joelpop joelpop self-assigned this Jul 8, 2024
@mshabarov mshabarov merged commit 5f404eb into main Aug 12, 2024
2 checks passed
@mshabarov mshabarov deleted the fix/#1811-AnchorTester-with-query-parameters branch August 12, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees

@joelpop joelpop

Labels
UITest JUnit testing the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AnchorTester should support Anchors having query parameters
3 participants
@joelpop @mcollovati @mshabarov