Address numpy int argument conversion issue #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As long as |
Pull Request Test Coverage Report for Build 8978758502Details
💛 - Coveralls |
arkid15r
commented
May 2, 2024
Comment on lines
+24
to
+29
| @pytest.mark.skipif( | ||
| platform().startswith("Windows") | ||
| and python_implementation().startswith("PyPy") | ||
| and python_version().startswith("3.10"), | ||
| reason='Avoid "make: *** [Makefile:63: test] Error 5" for pypy3.10 on Windows', | ||
| ) |
There was a problem hiding this comment.
It's not there yet :)
https://github.com/KJhellico/python-holidays/actions/runs/8928197300/job/24523240416
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Resolves #1779
This change fixes
yearsnumpy int incompatibility issue. In order to test it properly we'll neednumpypackage installed in the test environment. I'm still not sure if that's a great idea as it's not really 💯 PH issue. On the other hand Prophet is a huge part of our ecosystem and it'd be very nice of us to take care of the issue.FYI: there is a problem when running the new test on Windows pypy3.10 so I skipped it with
skipif. It looks likeimport numpycauses that. If anyone knows how to fix that please let me know.I also added pypy3.9 pypy3.10 to tox.ini env list.
@KJhellico @PPsyrius I'd like to know your opinion on this PR -- I'm open to removing the test or discarding the PR entirely based on your suggestions.
Thank you!
Type of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally