Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "St." to "Saint" in holidays names #1966

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Change "St." to "Saint" in holidays names (for en_US, fr locales and comments).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

sonarcloud bot commented Aug 31, 2024

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6ec8d56) to head (b8bc29f).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1966   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          188       188           
  Lines        11419     11422    +3     
  Branches      1795      1799    +4     
=========================================
+ Hits         11419     11422    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool beans @KJhellico!

I like the consistency and completeness based approach within this PR!

@arkid15r arkid15r added this pull request to the merge queue Aug 31, 2024
Merged via the queue into vacanza:dev with commit 1ae8509 Aug 31, 2024
31 checks passed
@KJhellico KJhellico deleted the loc-saint-unify branch August 31, 2024 18:03
@KJhellico KJhellico mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants