Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump numpy from 2.0.1 to 2.0.2 #2006

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

PPsyrius
Copy link
Collaborator

Proposed change

Actually bumps numpy from 2.0.1 to 2.0.2 - now at the correct section of the code. I suspect this will likely remain an issue until Python 3.8's deprecation date sometime this October...

Resolves #2003.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ed4c92d) to head (d88c255).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2006   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          188       188           
  Lines        11409     11409           
  Branches      1791      1791           
=========================================
  Hits         11409     11409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Sep 19, 2024
Merged via the queue into vacanza:dev with commit 18dc5c0 Sep 19, 2024
32 checks passed
@PPsyrius PPsyrius deleted the numpy_2.0.2_manual branch September 19, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants