feat(solana): add nullable tag #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gabrielKerekes
requested changes
May 6, 2024
RostarMarek
force-pushed
the
feat/add-nullable-flag
branch
4 times, most recently
from
c8b43bd
to
52289ec
Compare
Comment on lines
55
to
57
| if property_template.is_nullable and property_template.is_optional: | ||
| raise DataError("Parameter is nullable and optional") |
There was a problem hiding this comment.
Suggested change
| if property_template.is_nullable and property_template.is_optional: | |
| raise DataError("Parameter is nullable and optional") | |
| assert not (property_template.is_nullable and property_template.is_optional) # validated via mako template |
RostarMarek
force-pushed
the
feat/add-nullable-flag
branch
5 times, most recently
from
767484b
to
588414b
Compare
RostarMarek
force-pushed
the
feat/add-nullable-flag
branch
from
cb3bea8
to
52e2ba8
Compare
gabrielKerekes
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added nullable flag to help with parsing null for mint authority. Question in this is wheter the behavior of
optionalcreated from other sources is not the same as what we have defined here asnullable, in other words if the value will be always in the message but with a byte denoting wheter it is null.Also right now I do not think we should be able to have a param that is both
nullableandoptionalas it could lead to non deterministic parsing especially if there were multiple such params for 1 instruction.