-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huez v1.0.0 Theme manager #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: submit with invalid name error * refactor: define component var --------- Co-authored-by: Alberto Hernandez <121782036+vague2k@users.noreply.github.com>
- lazy attempts to call setup function when opts is passed to the registry init, which no all themes have. - some theme's names (the arg passed to `:colorscheme`) do not match repo name, so the colorscheme field was added to `ThemeRegistryEntry`
This reverts commit 9dbf8b4.
…ee comment i also added some `TODO` comments that are worth looking at
* refactor(manager): started, fix loop this commit is so i can keep working from my desktop you can ignore this for the most part. * refactor(manager): clean up file struct, add todo comments * refactor(manager): move init to `import` due to lazy conflicts * fix: needless `.init` infront of reqs because of LSP code actions
* feat: ensure installed themes * refactor(pickers): prefer `<space>` instead of `<leader>` * refactor(pickers): change prompt titles for `HuezLive` and `HuezEnsured` * refactor(pickers): create layout and picker builder * update TODO.md
* feat: favorites * fix: small docstring typo * refactor(tests): restructure tests, add favorites tests
Having generated lazy spec include an event like "UiEnter" creates a race condition whenever huez tries to set a colorscheme managed by huez
will work on this later in the afternoon
If we force merged values from the right table, being `api.live.installed`, the amount of themes in `api.ensured.installed` i.e ensured(n), would not be loaded in the `:HuezLive` picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huez v1.0.0
1.0 Stands to bring new features to Huez such as...
TODO
There are some stuff left to do and planned like...
Very huge thank you and acknowledgement to @tris203 for helping me out with the theme manager side of things.
This PR references #14 and #23