Skip to content

Commit

Permalink
chore: update assert.equal() to assert.strictEqual() (#1471)
Browse files Browse the repository at this point in the history
  • Loading branch information
yomed authored Oct 7, 2020
1 parent dbd2a4d commit 8f0d2f9
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
10 changes: 5 additions & 5 deletions test/client-side.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ describe('Minified version', () => {
it('should export the same things as the server-side version', () => {
for (let key in validator) {
if ({}.hasOwnProperty.call(validator, key)) {
assert.equal(
assert.strictEqual(
typeof validator[key],
typeof min[key], `Minified version did not export ${key}`
);
Expand All @@ -15,15 +15,15 @@ describe('Minified version', () => {
});

it('should be up to date', () => {
assert.equal(min.version, validator.version, 'Minified version mismatch. Run `make min`');
assert.strictEqual(min.version, validator.version, 'Minified version mismatch. Run `make min`');
});

it('should validate strings', () => {
assert.equal(min.isEmail('foo@bar.com'), true);
assert.equal(min.isEmail('foo'), false);
assert.strictEqual(min.isEmail('foo@bar.com'), true);
assert.strictEqual(min.isEmail('foo'), false);
});

it('should sanitize strings', () => {
assert.equal(min.toBoolean('1'), true);
assert.strictEqual(min.toBoolean('1'), true);
});
});
10 changes: 5 additions & 5 deletions test/exports.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@ import { locales as isFloatLocales } from '../src/lib/isFloat';

describe('Exports', () => {
it('should export validators', () => {
assert.equal(typeof validator.isEmail, 'function');
assert.equal(typeof validator.isAlpha, 'function');
assert.strictEqual(typeof validator.isEmail, 'function');
assert.strictEqual(typeof validator.isAlpha, 'function');
});

it('should export sanitizers', () => {
assert.equal(typeof validator.toBoolean, 'function');
assert.equal(typeof validator.toFloat, 'function');
assert.strictEqual(typeof validator.toBoolean, 'function');
assert.strictEqual(typeof validator.toFloat, 'function');
});

it('should export the version number', () => {
/* eslint-disable global-require */
assert.equal(
assert.strictEqual(
validator.version, require('../package.json').version,
'Version number mismatch in "package.json" vs. "validator.js"'
);
Expand Down
4 changes: 2 additions & 2 deletions test/validators.js
Original file line number Diff line number Diff line change
Expand Up @@ -4940,14 +4940,14 @@ describe('Validators', () => {

let sandbox = vm.createContext(window);
vm.runInContext(validator_js, sandbox);
assert.equal(window.validator.trim(' foobar '), 'foobar');
assert.strictEqual(window.validator.trim(' foobar '), 'foobar');
});

it('should bind validator to the window if no module loaders are available', () => {
let window = {};
let sandbox = vm.createContext(window);
vm.runInContext(validator_js, sandbox);
assert.equal(window.validator.trim(' foobar '), 'foobar');
assert.strictEqual(window.validator.trim(' foobar '), 'foobar');
});

it('should validate mobile phone number', () => {
Expand Down

0 comments on commit 8f0d2f9

Please sign in to comment.