Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isPostalCode for SE returns valid postal code for postal code with leading 0 #1008

Closed
simonlovesyou opened this issue Mar 27, 2019 · 1 comment
Closed

isPostalCode for SE returns valid postal code for postal code with leading 0 #1008

simonlovesyou opened this issue Mar 27, 2019 · 1 comment
Labels
🐛 bug

Comments

@simonlovesyou
Copy link

There are no postal codes in Sweden that starts with a leading 0 (Sorry for Swedish link)

So we should probably update the postal code regex to be something like ^[1-9]\d{2}\s?\d{2}$
simonlovesyou added a commit to simonlovesyou/validator.js that referenced this issue Mar 27, 2019
@simonlovesyou
Update SE isPostalCode.js
1e06d36 
Update to SE regexp to not consider postal codes in Sweden with a leading 0 to be a valid postal code

Fixes validatorjs#1008
@profnandaa
Copy link
Member

@simison - a PR is welcome, I see you already have some work on your branch?

ezkemboi added a commit to ezkemboi/validator.js that referenced this issue Jul 24, 2019
@ezkemboi
fix: ensure sweedish postal code does not allow start with 0
6cc1845 
- Authored by Ezrqn Kemboi <ezrqnkemboi@gmail.com>
- Close validatorjs#1008
@ezkemboi ezkemboi mentioned this issue Jul 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@profnandaa @chriso @simonlovesyou